Add the ability to have a delay before retrying#355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

mauriziovitale wants to merge2 commits intoactions:main

base:main

Choose a base branch

frommauriziovitale:ability-to-retry-with-delay

Open

Add the ability to have a delay before retrying#355

mauriziovitale wants to merge2 commits intoactions:mainfrommauriziovitale:ability-to-retry-with-delay

Conversation

Copy link

mauriziovitale commentedMar 27, 2023

No description provided.

Add the ability to have a delay before retrying

e778eeb

mauriziovitale requested a review froma team

March 27, 2023 15:50

mauriziovitale mentioned this pull request

Mar 27, 2023

Being able to define the retryAfter#354

Open

Copy link

Author

mauriziovitale commentedMar 28, 2023

It looks like there plugin-retry of octokit is using
const retryAfter = Math.pow((options.request.retryCount || 0) + 1, 2);
as value for retry.

Override the retryAfterBaseValue

2ca00a1

Copy link

Author

mauriziovitale commentedMar 28, 2023

Managed to override the retryAfterBaseValue to have a different delay

Copy link

Member

joshmgross commentedApr 4, 2023

It looks like there plugin-retry of octokit is using
const retryAfter = Math.pow((options.request.retryCount || 0) + 1, 2);
as value for retry.

Could you explain your use case? When would you want a fixed retry delay instead of exponential delay?

Copy link

Author

mauriziovitale commentedApr 5, 2023•
edited
Loading

It looks like there plugin-retry of octokit is using
const retryAfter = Math.pow((options.request.retryCount || 0) + 1, 2);
as value for retry.
Could you explain your use case? When would you want a fixed retry delay instead of exponential delay?

exponential is fine but I would like to have a starting point bigger than the default (1000)
for example I want to retry a call after 1min / 2min / 4min especially if you know that a cluster can take time to go up.