- Notifications
You must be signed in to change notification settings - Fork143
Fix vulnerability table duplication across manifests in comment summary#953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
alecbuchanan wants to merge1 commit intoactions:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Fix vulnerability table duplication across manifests in comment summary#953
alecbuchanan wants to merge1 commit intoactions:mainfromalecbuchanan:fix/vulnerability-table-duplication
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Move vulnerability table row array initialization inside manifest loopto prevent cross-contamination of vulnerability data between differentmanifest files (package.json, requirements.txt, etc).Previously, when multiple manifests contained vulnerabilities, the samerows array was being reused across all manifests, causing vulnerabilitiesto appear duplicated in subsequent manifest tables. This was due to therows array being declared once outside the manifest iteration loop.The fix ensures each manifest gets its own clean array by moving the`const rows: SummaryTableRow[] = []` declaration inside the for loopthat iterates over manifests.Added comprehensive test coverage:- Separate table creation for different manifests- Vulnerability deduplication across manifest tables- Multiple vulnerabilities per package in different manifests- Correct vulnerability grouping within manifestsAll existing tests continue to pass, confirming no regression infunctionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR fixes a bug where vulnerability table rows were being duplicated across different manifest files due to shared array reference. The fix moves the rows array initialization inside the manifest loop to ensure each manifest gets its own clean array.
- Moves
rowsarray declaration inside the manifest iteration loop - Adds comprehensive test coverage for multi-manifest vulnerability scenarios
- Ensures proper isolation of vulnerability data between manifests
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/summary.ts | Moves rows array initialization inside manifest loop to prevent cross-contamination |
| tests/summary.test.ts | Adds comprehensive test coverage for multi-manifest vulnerability scenarios |
Author
alecbuchanan commentedJul 29, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move vulnerability table row array initialization inside manifest loop to prevent cross-contamination of vulnerability data between different manifest files (package.json, requirements.txt, etc).
Previously, when multiple manifests contained vulnerabilities, the same rows array was being reused across all manifests, causing vulnerabilities to appear duplicated in subsequent manifest tables. This was due to the rows array being declared once outside the manifest iteration loop.
The fix ensures each manifest gets its own clean array by moving the
const rows: SummaryTableRow[] = []declaration inside the for loop that iterates over manifests.Added comprehensive test coverage:
All existing tests continue to pass, confirming no regression in functionality.