- Notifications
You must be signed in to change notification settings - Fork143
Update PR comment behavior foron-failure mode#941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
sgmurphy wants to merge2 commits intoactions:mainChoose a base branch fromsgmurphy:update-pr-comment
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
When comment_summary_in_pr is set to 'on-failure', the action now updatesexisting comments when issues are resolved in subsequent runs, providingclear feedback that dependency issues have been fixed.
Hey@dangoor 👋 , any chance I could get a review 👀 on this? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Summary
on-failuremode to update existing comments when issues are resolvedChanges
comment-pr.tsto handle success cases in on-failure mode by updating existing commentshasExistingCommenthelper function to check for existing dependency review commentsTest plan
Demo
Live demonstration of the enhanced functionality:
Demo 1: Enhanced
on-failuremode behaviorsgmurphy/fictional-garbanzo#1
on-failuremodeDemo 2:
nevermode validationsgmurphy/fictional-garbanzo#2
comment-summary-in-pr: neverproperly suppresses all comments