Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update PR comment behavior foron-failure mode#941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
sgmurphy wants to merge2 commits intoactions:main
base:main
Choose a base branch
Loading
fromsgmurphy:update-pr-comment

Conversation

@sgmurphy
Copy link
Contributor

@sgmurphysgmurphy commentedJun 17, 2025
edited
Loading

Summary

Changes

  • Modifiedcomment-pr.ts to handle success cases in on-failure mode by updating existing comments
  • AddedhasExistingComment helper function to check for existing dependency review comments
  • Added comprehensive test suite covering all comment modes and scenarios

Test plan

  • All existing tests pass
  • New tests cover all comment modes (always, never, on-failure)
  • Tests verify proper comment creation, updating, and skipping behavior
  • Edge cases handled (non-PR context, multiple comments)

Demo

Live demonstration of the enhanced functionality:

Demo 1: Enhancedon-failure mode behavior

sgmurphy/fictional-garbanzo#1

  • Demonstrates improved comment behavior inon-failure mode
  • Shows comment creation when vulnerabilities are found
  • Shows comment updating (not creating new ones) when vulnerabilities are resolved
  • Prevents comment spam by reusing existing comments

Demo 2:never mode validation

sgmurphy/fictional-garbanzo#2

  • Validates thatcomment-summary-in-pr: never properly suppresses all comments
  • Even with vulnerabilities present, no PR comments are created
  • Ensures "never" mode works correctly with the enhanced logic

When comment_summary_in_pr is set to 'on-failure', the action now updatesexisting comments when issues are resolved in subsequent runs, providingclear feedback that dependency issues have been fixed.
@sgmurphysgmurphy marked this pull request as ready for reviewJune 17, 2025 20:58
@sgmurphysgmurphy requested a review froma team as acode ownerJune 17, 2025 20:58
@sgmurphy
Copy link
ContributorAuthor

Hey@dangoor 👋 , any chance I could get a review 👀 on this?

niebloomj reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mark previous PR comment as outdated

1 participant

@sgmurphy

[8]ページ先頭

©2009-2025 Movatter.jp