Commit99c90f0

committed

fix: compatible with incomplete audio codec string mp4a.40

1 parent226ba8e commit99c90f0Copy full SHA for 99c90f0

File tree

+15

-1

lines changed

packages/av-cliper/src
- clips/__tests__
  - mp4-clip.test.ts
- mp4-utils
  - mp4box-utils.ts

+15

-1

lines changed

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -191,3 +191,14 @@ test('decode incorrectFrameTypeMp4', async () => {`
`191`	`191`	`const{ state}=awaitclip.tick(clip.meta.duration-30e3);`
`192`	`192`	`expect(state).toBe('success');`
`193`	`193`	`});`
	`194`	`+`
	`195`	+constmp4_webav1=`//${location.host}/video/webav1.mp4`;
	`196`	`+test('compatible with incomplete audio codec string mp4a.40',async()=>{`
	`197`	`+constclip=newMP4Clip((awaitfetch(mp4_webav1)).body!);`
	`198`	`+awaitclip.ready;`
	`199`	`+constspy=vi.spyOn(console,'error').mockImplementation(()=>{});`
	`200`	`+`
	`201`	`+awaitclip.tick(1e6);`
	`202`	`+expect(spy).not.toHaveBeenCalled();`
	`203`	`+spy.mockRestore();`
	`204`	`+});`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,10 @@ function parseAudioInfoFromESDSBox(esds: ESDSBoxParser): {`
`110`	`110`	`codec+='.'+decConfDesc.oti.toString(16);`
`111`	`111`
`112`	`112`	`constdecSpecInfo=decConfDesc.descs[0];`
`113`		`-if(decSpecInfo==null)return{ codec};`
	`113`	`+if(decSpecInfo==null){`
	`114`	`+if(codec.endsWith('40'))codec+='.2';`
	`115`	`+return{ codec};`
	`116`	`+}`
`114`	`117`
`115`	`118`	`// ref: https://wiki.multimedia.cx/index.php/MPEG-4_Audio#Audio_Specific_Config`
`116`	`119`	`constaudioObjectType=(decSpecInfo.data[0]&0xf8)>>3;`

Comments

(0)