Commit841a61a

Vince Speelman

committed

fix(creators): don't invoke promises. duh

I mistakenly evaluated promises in place upon generation. Instead, I'm now naievely assuming that ifyou return a function, you might need async actions. If you don't, no problem.

1 parent2de67ef commit841a61aCopy full SHA for 841a61a

File tree

1 file changed

-9

lines changed

src
- index.js

1 file changed

-9

lines changed

`‎src/index.js‎`

Lines changed: 2 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,13 +1,7 @@`
`1`	`1`	`import{createActionsasact}from'redux-actions';`
`2`	`2`
`3`	`3`	`constSTATES=['REQUESTED','RECEIVED','REJECTED'];`
`4`		`-constisPromise=value=>{`
`5`		`-lettest=value;`
`6`		`-if(typeofvalue==='function'){`
`7`		`-test=value();`
`8`		`-}`
`9`		`-returnPromise.resolve(test)===test;`
`10`		`-};`
	`4`	`+constisPromise=value=>Promise.resolve(value)===value;`
`11`	`5`
`12`	`6`	`constcreateActions=(`
`13`	`7`	`{ states=STATES, prefix=''}={`
`@@ -20,8 +14,7 @@ const createActions = (`
`20`	`14`	`(acc,[k,v])=>({`
`21`	`15`	`...acc,`
`22`	`16`	`[k]:isPromise(v) ?()=>v :v,`
`23`		`- ...(v&&`
`24`		`-isPromise(v)&&`
	`17`	`+ ...(((v&&isPromise(v))\|\|typeofv==='function')&&`
`25`	`18`	`states.reduce(`
`26`	`19`	`(acc,curr)=>({`
`27`	`20`	`...acc,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit841a61a

File tree

1 file changed

1 file changed

`‎src/index.js‎`

0 commit comments