Commit99b3db9

and

markzegarelli

authored

Apply suggestions from code review

Co-authored-by: markzegarelli <mark.zegarelli@segment.com>

1 parent9d15b64 commit99b3db9Copy full SHA for 99b3db9

File tree

-3

lines changed

-3

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ database shortly.`
`87`	`87`	`If your Db2 Warehouse is in a private network, be sure to[whitelist`
`88`	`88`	`Segment's IP`
`89`	`89`	`address](https://segment.com/docs/connections/storage/warehouses/faq/#which-ips-should-i-whitelist).`
`90`		`-Otherwise, Segmentwon't be able to load your data.`
	`90`	`+Otherwise, Segmentcan't load your data.`
`91`	`91`
`92`	`92`	`###Unique User`
`93`	`93`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -356,7 +356,7 @@ GRANT CREATE, TEMPORARY ON DATABASE <enter database name here> TO segment;`
`356`	`356`	`## Security`
`357`	`357`	`To make sure your Postgres database is secure:`
`358`	`358`	`- Login with a user that has readand write permissions so that Segment can write to your database.`
`359`		-- Whitelist the Segment IP (`52.25.130.38/32`). Otherwise, Segmentwon't be able to load your data.
	`359`	+- Whitelist the Segment IP (`52.25.130.38/32`). Otherwise, Segmentcan't load your data.
`360`	`360`	- Create a service user that has `read/write` permissions.
`361`	`361`	`- Always require SSL/TLS and make sure your data warehouse can only accept secure connections. Segment only connects to your data warehouse using SSL/TLS.`
`362`	`362`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ After creating a Redshift warehouse, the next step is to connect Segment:`
`70`	`70`	`VPCs keep servers inaccessible to traffic from the internet. With VPC, you're able to designate specific web servers access to your servers. In this case, you will be whitelisting the[Segment IPs](/docs/connections/storage/warehouses/faq#which-ips-should-i-whitelist) to write to your data warehouse.`
`71`	`71`
`72`	`72`	`###SSL/TLS`
`73`		`-Always require SSL/TLS and make sure your data warehousecan only accept secure connections. Segment only connects to your data warehouse using SSL/TLS.`
	`73`	`+Always require SSL/TLS and make sure your data warehouseaccepts only secure connections. Segment only connects to your data warehouse using SSL/TLS.`
`74`	`74`
`75`	`75`	`##Best practices`
`76`	`76`

Comments

(0)