- Notifications
You must be signed in to change notification settings - Fork37
[wip] Remove SimpleVarInfo#1152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
penelopeysm wants to merge21 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
* Fast Log Density Function* Make it work with AD* Optimise performance for identity VarNames* Mark `get_range_and_linked` as having zero derivative* Update comment* make AD testing / benchmarking use FastLDF* Fix tests* Optimise away `make_evaluate_args_and_kwargs`* const func annotation* Disable benchmarks on non-typed-Metadata-VarInfo* Fix `_evaluate!!` correctly to handle submodels* Actually fix submodel evaluate* Document thoroughly and organise code* Support more VarInfos, make it thread-safe (?)* fix bug in parsing ranges from metadata/VNV* Fix get_param_eltype for TSVI* Disable Enzyme benchmark* Don't override _evaluate!!, that breaks ForwardDiff (sometimes)* Move FastLDF to experimental for now* Fix imports, add tests, etc* More test fixes* Fix imports / tests* Remove AbstractFastEvalContext* Changelog and patch bump* Add correctness tests, fix imports* Concretise parameter vector in tests* Add zero-allocation tests* Add Chairmarks as test dep* Disable allocations tests on multi-threaded* Fast InitContext (#1125)* Make InitContext work with OnlyAccsVarInfo* Do not convert NamedTuple to Dict* remove logging* Enable InitFromPrior and InitFromUniform too* Fix `infer_nested_eltype` invocation* Refactor FastLDF to use InitContext* note init breaking change* fix logjac sign* workaround Mooncake segfault* fix changelog too* Fix get_param_eltype for context stacks* Add a test for threaded observe* Export init* Remove dead code* fix transforms for pathological distributions* Tidy up loads of things* fix typed_identity spelling* fix definition order* Improve docstrings* Remove stray comment* export get_param_eltype (unfortunatley)* Add more comment* Update comment* Remove inlines, fix OAVI docstring* Improve docstrings* Simplify InitFromParams constructor* Replace map(identity, x[:]) with [i for i in x[:]]* Simplify implementation for InitContext/OAVI* Add another model to allocation testsCo-authored-by: Markus Hauru <markus@mhauru.org>* Revert removal of dist argument (oops)* Format* Update some outdated bits of FastLDF docstring* remove underscores---------Co-authored-by: Markus Hauru <markus@mhauru.org>
* print output* fix* reenable* add more lines to guide the eye* reorder table* print tgrad / trel as well* forgot this type
… and also `bundle_samples` (#1129)* Implement `ParamsWithStats` for `FastLDF`* Add comments* Implement `bundle_samples` for ParamsWithStats -> MCMCChains* Remove redundant comment* don't need Statistics?
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mainly a PR to store the commit I did removing SimpleVarInfo, since we're separating this from#1139. It may well be that this is pointless (because removing code is quite easy to do, and merge conflicts might make this PR harder to work with). But it also doesn't hurt to dump this on a GitHub server.