Commit331279c

committed

Split up tilde_observe!! for Distribution / Submodel

1 parent13988b5 commit331279cCopy full SHA for 331279c

File tree

-5

lines changed

-5

lines changed

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -60,9 +60,11 @@ accumulate the log probability, and return the observed value and updated `vi`.
`60`	`60`	Falls back to `tilde_observe!!(context, right, left, vi)` ignoring the information about variable name
`61`	`61`	`and indices; if needed, these can be accessed through this function, though.`
`62`	`62`	`"""`
`63`		`-functiontilde_observe!!(::DefaultContext, right, left, vn, vi)`
`64`		`- rightisa DynamicPPL.Submodel&&`
`65`		-throw(ArgumentError("`x ~ to_submodel(...)` is not supported when `x` is observed"))
	`63`	`+functiontilde_observe!!(::DefaultContext, right::Distribution, left, vn, vi)`
`66`	`64`	`vi=accumulate_observe!!(vi, right, left, vn)`
`67`	`65`	`return left, vi`
`68`	`66`	`end`
	`67`	`+`
	`68`	`+functiontilde_observe!!(::DefaultContext,::DynamicPPL.Submodel, left, vn, vi)`
	`69`	+throw(ArgumentError("`x ~ to_submodel(...)` is not supported when `x` is observed"))
	`70`	`+end`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ struct DynamicTransformationContext{isinverse} <: AbstractContext end`
`13`	`13`	`NodeTrait(::DynamicTransformationContext)=IsLeaf()`
`14`	`14`
`15`	`15`	`functiontilde_assume!!(`
`16`		`-::DynamicTransformationContext{isinverse}, right, vn, vi`
	`16`	`+::DynamicTransformationContext{isinverse}, right::Distribution, vn, vi`
`17`	`17`	`)where {isinverse}`
`18`	`18`	`# vi[vn, right] always provides the value in unlinked space.`
`19`	`19`	`x= vi[vn, right]`
`@@ -31,7 +31,7 @@ function tilde_assume!!(`
`31`	`31`	`return x, vi`
`32`	`32`	`end`
`33`	`33`
`34`		`-functiontilde_observe!!(::DynamicTransformationContext, right, left, vn, vi)`
	`34`	`+functiontilde_observe!!(::DynamicTransformationContext, right::Distribution, left, vn, vi)`
`35`	`35`	`returntilde_observe!!(DefaultContext(), right, left, vn, vi)`
`36`	`36`	`end`
`37`	`37`

Comments

(0)