- Notifications
You must be signed in to change notification settings - Fork656
With fixed overlay and division by zero fixed#358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
marcelstoer commentedJan 4, 2022
Looking good, thanks! Please add an example sketch that demonstrates how to use this and some documentation to the README. Maybe an animated GIF for the README? |
| #include"OLEDDisplay.h" | ||
| #include<stdlib.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What do you need this one for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry, there’s a war in Ukraine and my Ukrainian home has been destroyed by russian nazi so I cannot check. I suppose, vscode added it automatically for some call. Could you check it please. It’s easy - just comment it out and try to compile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hi!
Maybe we could return to this, could we? What should I do? Add an example and that's all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for coming back to this. If you could address my feedback I'd certainly appreciate it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
gimme some time pls, I cannot get arduion working yet. looks like they changed something
Uh oh!
There was an error while loading.Please reload this page.
Resolves#356:
3 methods added to the API:
void setFixedOverlay(FixedOverlayCallback fixedOverlayCallback)to set fixed overlay drawing foo.void setFixedOverlayFrames(const FrameCallback* fixedOverlayFramesList, int noOverlayFramesCount)to set the list of frames on which this fixed overlay will be drawn (by specifying frames callbacks, which could be useful during list changes).void setFixedOverlayFrames(int* fixedOverlayFramesList, int noOverlayFramesCount)to set the list of frames on which this fixed overlay will be drawn (by specifying frames numbers)Usage example:
FrameCallback frames[] = { frame1, frame2, frame3, frame4, frame5};int framesCount =5;... ui.setFixedOverlay(someOverlayFoo); ui.setFixedOverlayFrames((const FrameCallback[]){frame2, frame3, frame5},3);// or ui.setFixedOverlayFrames((constuint8_t[]){1,2,4},3);