Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork49.6k
Fix mypy errors in the entire codebase#8577
-
We need to fix all the
So, do we switch to Python 3.9 compatible type hints or advise users to user the |
BetaWas this translation helpful?Give feedback.
All reactions
Replies: 3 comments
-
At this point, we should switch to Python 3.9 (dropping any dependencies which are not ready) and then mypy should accept the syntax without the future import. |
BetaWas this translation helpful?Give feedback.
All reactions
-
That would probably fail some of the checks as some files could rely on that dependency. |
BetaWas this translation helpful?Give feedback.
All reactions
-
I suggest a phased approach for Python 3.9 migration and mypy error fixes: 1. Retain Python 3.8+ compatibility first: Keep using typing.List instead of native list[type] for now, since CI doesn’t support 3.9 yet due to dependency issues. This fixes the mypy errors and keeps the codebase stable. |
BetaWas this translation helpful?Give feedback.