Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.7k
Added the optimized solution for promblem 44#1324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Sir please check the code let me know if there is any error |
appgurueu left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
CI is failing.
Please adapt the tests; they can't possibly work for this, since you renamed the function.
Second, the comments are very redundant with the code (and also read as if they had been written by a certain large language model).pentagonalIndices
isn't a set of indices, it's a set of numbers.
I also don't see how this is supposed to be "O(n)" considering it has two nested for loops which I would assume to be O(n²) given that both for loops look like they are roughly O(k). What even is n?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Optimised the solution for problem 44 in o(n) time complexity.