Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added the optimized solution for promblem 44#1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
utkarsh-shrivastav77 wants to merge1 commit intoTheAlgorithms:master
base:master
Choose a base branch
Loading
fromutkarsh-shrivastav77:master

Conversation

utkarsh-shrivastav77

Optimised the solution for problem 44 in o(n) time complexity.

@utkarsh-shrivastav77
Copy link
Author

Sir please check the code let me know if there is any error

Copy link
Collaborator

@appgurueuappgurueu left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

CI is failing.

Please adapt the tests; they can't possibly work for this, since you renamed the function.

Second, the comments are very redundant with the code (and also read as if they had been written by a certain large language model).pentagonalIndices isn't a set of indices, it's a set of numbers.

I also don't see how this is supposed to be "O(n)" considering it has two nested for loops which I would assume to be O(n²) given that both for loops look like they are roughly O(k). What even is n?

@stale
Copy link

stalebot commentedJun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stalestalebot added the staleClosed due to age labelJun 18, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@appgurueuappgurueuappgurueu left review comments

@raklaptudirmraklaptudirmAwaiting requested review from raklaptudirmraklaptudirm is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
staleClosed due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@utkarsh-shrivastav77@appgurueu

[8]ページ先頭

©2009-2025 Movatter.jp