Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Added Miller Rabin Primality Test#1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
sundaram123krishnan wants to merge9 commits intoTheAlgorithms:master
base:master
Choose a base branch
Loading
fromsundaram123krishnan:master

Conversation

sundaram123krishnan
Copy link

@sundaram123krishnansundaram123krishnan commentedMay 4, 2023•
edited
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

@sundaram123krishnan
Copy link
Author

someone help with indentation pls , thx in advance

Copy link
Collaborator

@appgurueuappgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

  • Try adding more comments to the code (but do not add redundant comments).
  • Add tests.
  • What are the changes topackage.json andpackage-lock.json for? They look accidental to me.

@appgurueu
Copy link
Collaborator

someone help with indentation pls , thx in advance

You should be able to simply runhttps://standardjs.com/ against your code.

@sundaram123krishnan
Copy link
Author

yaa actually i had added npm format package

@sundaram123krishnan
Copy link
Author

now it works, thx

@sundaram123krishnan
Copy link
Author

deleted

@sundaram123krishnan
Copy link
Author

any further changes to be done ?@appgurueu

Copy link
Collaborator

@appgurueuappgurueu left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Still missing tests and comments. For example you use exponentation by squaring, but don't explain this using comments. Also still contains the unrelatedpackage[-lock].json changes.

@sundaram123krishnan
Copy link
Author

should i add more comments explaining this algorithm?

@stale
Copy link

stalebot commentedJun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stalestalebot added the staleClosed due to age labelJun 18, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@raklaptudirmraklaptudirmAwaiting requested review from raklaptudirmraklaptudirm is a code owner

@appgurueuappgurueuAwaiting requested review from appgurueuappgurueu is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
staleClosed due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@sundaram123krishnan@appgurueu
[8]ページ先頭
©2009-2025 Movatter.jp