Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.7k
Update LFUCache.js#1320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
shpetimaliu wants to merge1 commit intoTheAlgorithms:masterChoose a base branch fromshpetimaliu:patch-1
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Update LFUCache.js#1320
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- I think It is not necessary to use Object.seal in CacheNode and LFUCache since you are not modifying anything in them after they are created.- In insert and refresh in FrequencyMap, you don't need to create a new Set if a specific frequency doesn't exist in the Map. It could be created immediately and would be more efficient.- In LFUCache, instead of calling the methods cache.has(key) and cache.get(key), you can access the cache value directly using this.cache.get(key) and this.cache.has(key). This is shorter and clearer.
CI is failing. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think It is not necessary to use Object.seal in CacheNode and LFUCache since you are not modifying anything in them after they are created.
In insert and refresh in FrequencyMap, you don't need to create a new Set if a specific frequency doesn't exist in the Map. It could be created immediately and would be more efficient.
In LFUCache, instead of calling the methods cache.has(key) and cache.get(key), you can access the cache value directly using this.cache.get(key) and this.cache.has(key). This is shorter and clearer.
Describe your change:
Checklist:
Example:
UserProfile.js
is allowed butuserprofile.js
,Userprofile.js
,user-Profile.js
,userProfile.js
are notFixes: #{$ISSUE_NO}
.