Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update LFUCache.js#1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
shpetimaliu wants to merge1 commit intoTheAlgorithms:master
base:master
Choose a base branch
Loading
fromshpetimaliu:patch-1

Conversation

shpetimaliu
Copy link

  • I think It is not necessary to use Object.seal in CacheNode and LFUCache since you are not modifying anything in them after they are created.

  • In insert and refresh in FrequencyMap, you don't need to create a new Set if a specific frequency doesn't exist in the Map. It could be created immediately and would be more efficient.

  • In LFUCache, instead of calling the methods cache.has(key) and cache.get(key), you can access the cache value directly using this.cache.get(key) and this.cache.has(key). This is shorter and clearer.

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

- I think It is not necessary to use Object.seal in CacheNode and LFUCache since you are not modifying anything in them after they are created.- In insert and refresh in FrequencyMap, you don't need to create a new Set if a specific frequency doesn't exist in the Map. It could be created immediately and would be more efficient.- In LFUCache, instead of calling the methods cache.has(key) and cache.get(key), you can access the cache value directly using this.cache.get(key) and this.cache.has(key). This is shorter and clearer.
@appgurueu
Copy link
Collaborator

CI is failing.

@stale
Copy link

stalebot commentedJun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stalestalebot added the staleClosed due to age labelJun 18, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@raklaptudirmraklaptudirmAwaiting requested review from raklaptudirmraklaptudirm is a code owner

@appgurueuappgurueuAwaiting requested review from appgurueuappgurueu is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
staleClosed due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@shpetimaliu@appgurueu

[8]ページ先頭

©2009-2025 Movatter.jp