Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.7k
Two sum#1226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Two sum#1226
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Data-Structures/Array/TwoSum.js Outdated
| @@ -0,0 +1,24 @@ | |||
| // https://leetcode.com/problems/two-sum/ | |||
| // Given an array of integers, return indices of the two numbers such that they add up to | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you try to use a JSDoc comment right above the definition ofTwoSum?
| import { TwoSum } from '../TwoSum' | ||
| describe('TwoSum tests', () => { | ||
| it('check that a variety of inputs return the correct answer', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just usetest("Two Sum", () => ...) right away
| // Because nums[0] + nums[1] = 2 + 7 = 9, | ||
| // return [0, 1]. | ||
| const TwoSum = (nums, target) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That's a pretty naive implementation with a runtime of O(n²). Please document this in the JSDoc comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please seethe docs and use the proper@annotations.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Uh oh!
There was an error while loading.Please reload this page.
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.