NotificationsYou must be signed in to change notification settings
Fork19.9k
Star61.7k

Add exponential search algorithm#6218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

vieriloh wants to merge1 commit intoTheAlgorithms:master

base:master

Choose a base branch

fromvieriloh:feature/exponential-search

Open

Add exponential search algorithm#6218

vieriloh wants to merge1 commit intoTheAlgorithms:masterfromvieriloh:feature/exponential-search

Conversation

Copy link

vieriloh commentedApr 11, 2025

This pull request adds a new implementation of the Exponential Search algorithm under the searchs package (com.thealgorithms.searchs).
Exponential Search is an efficient algorithm for searching sorted arrays. It works by finding a range where the element is likely to be and then performing Binary Search within that range.

Key Details:

Method: search(int[] arr, int x)

Includes a helper binarySearch method

Added test logic in main method for quick verification

This feature is part of my assignment for software configuration and quality practices, demonstrating version control, branching, and collaborative workflow.

Add exponential search algorithm

8b86539

vieriloh requested review fromyanglbme,vil02,BamaCharanChhandogi,alxkm andsiriak ascode owners

April 11, 2025 21:59

Copy link

codecov-commenter commentedApr 11, 2025

Codecov Report

Attention: Patch coverage is0% with21 lines in your changes missing coverage. Please review.

Project coverage is 73.70%. Comparing base(f53bc00) to head(8b86539).

Files with missing lines	Patch %	Lines
...a/com/thealgorithms/searchs/ExponentialSearch.java	0.00%	21 Missing⚠️

Additional details and impacted files

@@             Coverage Diff              @@##             master    #6218      +/-   ##============================================- Coverage     73.79%   73.70%   -0.09%  Complexity     5303     5303              ============================================  Files           672      673       +1       Lines         18357    18378      +21       Branches       3549     3554       +5     ============================================  Hits          13546    13546- Misses         4264     4285      +21  Partials        547      547

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

DenizAltunkapan requested changes

Apr 12, 2025

View reviewed changes

Copy link

Collaborator

DenizAltunkapan left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There needs to be a fix for the unused import, the addition of a private constructor to the utility class, and the inclusion of curly braces for all 'if'/'else' blocks to improve readability and consistency and pass the actions that failed

src/main/java/com/thealgorithms/searchs/ExponentialSearch.java

		@@ -0,0 +1,48 @@
		package com.thealgorithms.searchs;

		import java.util.Arrays;

Copy link

Collaborator

DenizAltunkapanApr 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think there might be an unused import. Is this necessary?

src/main/java/com/thealgorithms/searchs/ExponentialSearch.java


		import java.util.Arrays;

		public class ExponentialSearch {

Copy link

Collaborator

DenizAltunkapanApr 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think you need to insert a private constructor because the default constructor from the Object class is public

src/main/java/com/thealgorithms/searchs/ExponentialSearch.java

		int n = arr.length;

		// If the element is present at the first position
		if (arr[0] == x) return 0;

Copy link

Collaborator

DenizAltunkapanApr 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It's recommended to use curly braces for 'if' blocks, even for single statements

src/main/java/com/thealgorithms/searchs/ExponentialSearch.java

		while (low <= high) {
		int mid = low + (high - low) / 2;

		if (arr[mid] == x) return mid;

Copy link

Collaborator

DenizAltunkapanApr 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

there are also here curly braces needed

src/main/java/com/thealgorithms/searchs/ExponentialSearch.java


		if (arr[mid] == x) return mid;

		if (arr[mid] < x) low = mid + 1;

Copy link

Collaborator

DenizAltunkapanApr 12, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It's necessary to use curly braces for 'if' and 'else' blocks, even for single statements

Copy link

Member

siriak commentedApr 12, 2025

Please also check these gates

Copy link

Collaborator

DenizAltunkapan commentedApr 12, 2025•
edited
Loading

Please also check these gates

these gates should pass after he implements the requested changes above but i recommend you to run clang formatter manually@vieriloh

Copy link

Contributor

huseynovvusal commentedApr 17, 2025•
edited
Loading

Hello,@vieriloh! You can simply remove the unusedjava.util.Arrays import, adda private constructor to the utils class so it can’t be instantiated, and wrap all yourif-else blocks in braces. Hope it will help you. :)

Copy link

github-actionsbot commentedMay 18, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution!