- Notifications
You must be signed in to change notification settings - Fork63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Allow Justification on Buttons, ToggleButtons and Labels#28
Open
Jamie-Booth wants to merge3 commits intoTankOs:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Added the ability to justify text (left, centre, right) for a button,togglebutton and label, which alsoFixes#27. Examples have not beencreated as yet, and current examples impacted by this change have notbeen updated. I'll do this once the change is approved.
Sorry, got out of sync from my dev branch to this master branch.
Hey, thanks for your contribution, and sorry for the late reply. I added it to my review list and wi come back once I find time to check it. :) |
No worries. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code will allow buttons, togglebuttons and labels to be justified. It currently does not validate or default it the provided position to a valid one. A position can be provided to appear outside of the widgets allocation and it will do so (displaying nothing).
I'll correct that before the final pull request, this is just to get initial feedback before too much work is done.
Left Justified aligns on the start of the text.
Centre Justified (default) aligns on the centre of the text.
Right Justified aligns on the end of the text.
Fixes#27