- Notifications
You must be signed in to change notification settings - Fork5
Update llsp.c#2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
planetA commentedFeb 21, 2023
The PR should follow certain rules. Most importantly a PR must be descriptive. This means that you need to describe a problem you are trying to solve (or feature you are trying to add) and in general terms explain how you solve it. The title of the pull request also must be descriptive. |
| size_tmetrics;// metrics count | ||
| double*data;// pointer to the malloc'ed data block, matrix is transposed | ||
| structmatrixfull;// pointers to the matrix in its original form with all columns | ||
| structmatrixfull;// pointers to the matrix in its original form with all columns 指向具有所有列的原始形式的矩阵的指针 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do not put comments in Chinese in a repo that is supposed to be widely accessible.
| constsize_tindex_last=llsp->good.columns-1; | ||
| free(llsp->good.matrix[index_last]); | ||
| // fprintf(stderr, "good.matrix = %p, index_last = %lu\n", llsp->good.matrix, index_last); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is a comment left from "printf-debugging" now it serves no purpose. Remove it.
| llsp->metrics=count; | ||
| llsp->full.columns=count+1; | ||
| llsp->sort.columns=count+1; | ||
| llsp->good.columns=count+1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why is assignment required?
| free(llsp->good.matrix[index_last]); | ||
| // fprintf(stderr, "good.matrix = %p, index_last = %lu\n", llsp->good.matrix, index_last); | ||
| if (llsp->good.matrix) { | ||
| free(llsp->good.matrix[index_last]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Shouldn't there be some loop over all columns? Not just the last one?
No description provided.