- Notifications
You must be signed in to change notification settings - Fork162
Added support for View optionals, fixing @ViewBuilder conditionals.#58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Samuel-IH wants to merge1 commit intoSwiftWebUI:developChoose a base branch
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Previously conditionals had to have a trailing "else {...}" at the end because of lack of optional support from the View protocol.This fix will introduce View optionals and make the behavior more like SwiftUI's View.(cherry picked from commit223bc36)Member
helje5 commentedSep 18, 2020
Thanks for your PRs! It'll take me a while to find the time to review the things. |
| //support for optional Views, mainly for @ViewBuilder convenience | ||
| extensionOptional:Viewwhere Wrapped:View{ | ||
| publicvarbody:EmptyView{ | ||
| EmptyView() |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Better late than never, but that seems wrong. The Optional View should be the wrapped if set, and EmptyView only in the .none case.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously conditionals had to have a trailing "else {...}" at the end because of lack of optional support from the View protocol.
This fix will introduce View optionals and make the behavior more like SwiftUI's View.
Note:
I had to add an optional check inside ComponentReflection.swift, I'm not 100% sure of the inner workings of this file but this doesn't seem to be causing any conflicts.