Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork443
Ensuring that drag does not move slides more thanoptions.flickMaxPages allows#1118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Kreeg wants to merge1 commit intoSplidejs:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
options.flickMaxPages allowssimonbrunel commentedMar 17, 2023
tomikaka22 commentedMar 26, 2023
Would love this to be fixed. |
Author
Kreeg commentedApr 3, 2023
You can switch to our fork for now |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If you drag the slider too fast, it moves more than
options.flickMaxPages.For example, there is a problem with caused with this config.
video5411494184043422802.mp4
In this video you can see that sometimes slider moves more than 1 page. After some digging I found that this is
computeDestinations problem. In fact, it'sgetPositionthat causes this error. If you drag fast, it calculates that you are already at the next slide, but in reality, you are not.So in this case I just added a new additional check that splide does not move more than it should.
Sorry for no related issue. This started as a local critical bug on our website so we can't wait too long. We have already switched to a forked version and have tested it in production mode. But I added more unit-tests to be sure.