- Notifications
You must be signed in to change notification settings - Fork160
feat: migrate to Angular 12#246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Anikethana commentedSep 18, 2021
Can you merge this PR? |
nicolashenry commentedNov 17, 2021
@smnbbrv Can you merge/release this? Or maybe can you give us a contact from someone who could do that for this repository? |
Deitsch commentedNov 24, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Can we merge this branch. I think many people who want to use sortablejs would need this. If it's unsupported maybe a new maintainer could be found? |
Reixko commentedJan 24, 2022
I'm very Sorry for tagging you, but could you please merge this ? This is here already for 4 months |
andresin87 commentedJan 25, 2022
I'm sorry. I just got enrolled to the team half a month ago just for the react sortable binding project. |
Reixko commentedJan 25, 2022
No problem, could you maybe ping someone from the team that can merge this ? Because if they enrolled you, then it means that atleast someone is active :) Thank you@andresin87 |
spierala commentedApr 15, 2022
@Anikethana I believe that we should add "compilationMode": "partial" in the libs prod tsconfig https://angular.io/guide/creating-libraries#ensuring-library-version-compatibility |
| { | ||
| "$schema":"./node_modules/@angular/cli/lib/config/schema.json", | ||
| "cli": { | ||
| "analytics":"97b059d8-f275-47b1-ad17-9665c85827b3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What is this? Better remove I would say.
jpark011 commentedApr 19, 2022
Also need to update peerDependencies onpackage.json |
kiran-pathe commentedApr 20, 2022
Can you also update package.json file |
Klapik commentedJul 11, 2022
Is this project dead? |
Deitsch commentedJul 12, 2022
seems to be dead, i wouldn't use it if you have other options |
COBRASoft5 commentedJul 12, 2022
Unfortunately, I can't find a good alternative. Dragula is also dead for quite some time now. |
Deitsch commentedJul 12, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This are some alternatives that are maintained. The downside of the first and second is that they aren't as conveniently wrapped for Angular. But it recommend going down this path rather then to use the seemingly unmaintained sortablejs https://github.com/Shopify/draggable Also simple stuff can be done using the HTML drag API. It's not too shabby. I created my own directives for a folder like, multi object dnd |
COBRASoft5 commentedJul 12, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
SortableJS is one of the only frameworks that works nicely together with multiple columns and rows (grid). Most others, like cdk, don't have nice animations or don't work at all in a grid display. Edit: seems draggable is not very well maintained either as mentioned on their github page. |
Deitsch commentedJul 12, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
You are right about draggable, but at the moment is maintained and they search for maintainers, so i'd say it is a valid option. I mean you always can fork ngx-sortableJS it and bring it up to Angular 14 (or whatever version u need) |
AlexanderStromer commentedOct 10, 2023
@smnbbrv |
Used ng upgrade to update