Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: migrate to Angular 12#246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Anikethana wants to merge1 commit intoSortableJS:master
base:master
Choose a base branch
Loading
fromAnikethana:master

Conversation

@Anikethana
Copy link

Used ng upgrade to update

imtiazShakil reacted with thumbs up emoji
@AnikethanaAnikethana mentioned this pull requestSep 18, 2021
@Anikethana
Copy link
Author

Can you merge this PR?
I need support for Angular 12 for my project

obeardwood, gladkiy, sgruhier, dougellison, Deitsch, Malstrime, gabucito, beldenge, ramtel2005, ameryousuf, and 4 more reacted with thumbs up emoji

@nicolashenry
Copy link

@smnbbrv Can you merge/release this? Or maybe can you give us a contact from someone who could do that for this repository?

@Deitsch
Copy link

Deitsch commentedNov 24, 2021
edited
Loading

Can we merge this branch. I think many people who want to use sortablejs would need this. If it's unsupported maybe a new maintainer could be found?

@Reixko
Copy link

I'm very Sorry for tagging you, but could you please merge this ? This is here already for 4 months
@gutenye@David-Desmaisons@andresin87@eriklieben@matyas-igor@depuits@smnbbrv@owen-m1

imtiazShakil reacted with thumbs up emoji

@andresin87
Copy link
Member

I'm very Sorry for tagging you, but could you please merge this ? This is here already for 4 months@gutenye@David-Desmaisons@andresin87@eriklieben@matyas-igor@depuits@smnbbrv@owen-m1

I'm sorry. I just got enrolled to the team half a month ago just for the react sortable binding project.

@Reixko
Copy link

No problem, could you maybe ping someone from the team that can merge this ? Because if they enrolled you, then it means that atleast someone is active :) Thank you@andresin87

@spierala
Copy link

@Anikethana I believe that we should add "compilationMode": "partial" in the libs prod tsconfig

https://angular.io/guide/creating-libraries#ensuring-library-version-compatibility

{
"$schema":"./node_modules/@angular/cli/lib/config/schema.json",
"cli": {
"analytics":"97b059d8-f275-47b1-ad17-9665c85827b3"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What is this? Better remove I would say.

imtiazShakil and MIKOLAJW197 reacted with thumbs up emoji
@jpark011
Copy link

Also need to update peerDependencies onpackage.json

@kiran-pathe
Copy link

Used ng upgrade to update

Can you also update package.json file

@Klapik
Copy link

Is this project dead?

imtiazShakil reacted with confused emoji

@Deitsch
Copy link

seems to be dead, i wouldn't use it if you have other options

@COBRASoft5
Copy link

Unfortunately, I can't find a good alternative. Dragula is also dead for quite some time now.

@Deitsch
Copy link

Deitsch commentedJul 12, 2022
edited
Loading

This are some alternatives that are maintained. The downside of the first and second is that they aren't as conveniently wrapped for Angular. But it recommend going down this path rather then to use the seemingly unmaintained sortablejs

https://github.com/Shopify/draggable
https://github.com/taye/interact.js
https://material.angular.io/cdk/drag-drop/overview

Also simple stuff can be done using the HTML drag API. It's not too shabby. I created my own directives for a folder like, multi object dnd

@COBRASoft5
Copy link

COBRASoft5 commentedJul 12, 2022
edited
Loading

SortableJS is one of the only frameworks that works nicely together with multiple columns and rows (grid). Most others, like cdk, don't have nice animations or don't work at all in a grid display.

Edit: seems draggable is not very well maintained either as mentioned on their github page.

@Deitsch
Copy link

Deitsch commentedJul 12, 2022
edited
Loading

You are right about draggable, but at the moment is maintained and they search for maintainers, so i'd say it is a valid option.

I mean you always can fork ngx-sortableJS it and bring it up to Angular 14 (or whatever version u need)

@AlexanderStromer
Copy link

@smnbbrv
possible to update or assign to someone new maintaining it?
sorry to see this lib not being maintained. Angular native DragDrop has its downsides ...

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@spieralaspieralaspierala left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@Anikethana@nicolashenry@Deitsch@Reixko@andresin87@spierala@jpark011@kiran-pathe@Klapik@COBRASoft5@AlexanderStromer

[8]ページ先頭

©2009-2025 Movatter.jp