Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

core(openai): map temperature/top_p for Responses API; align ChatComp…#129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
thekavishshah wants to merge1 commit intoSmythOS:main
base:main
Choose a base branch
Loading
fromthekavishshah:fix/openai-responses-mapping-and-vault-watcher

Conversation

@thekavishshah
Copy link

…letions tool transform defaults to satisfy malformed tool config tests; security(vault): guard JSONFileVault watcher when no vault file provided to prevent chokidar errors\n\n- Add null checks before file watching\n- Add temperature and top_p to Responses API body when provided\n- Preserve undefined shapes in ChatCompletions transform for error-case parity\n- All affected core OpenAI unit tests pass locally

📝 Description

🔗 Related Issues

  • Fixes #
  • Relates to #

🔧 Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 📚 Documentation update
  • 🔧 Code refactoring (no functional changes)
  • 🧪 Test improvements
  • 🔨 Build/CI changes

✅ Checklist

  • Self-review performed
  • Tests added/updated
  • Documentation updated (if needed)

…letions tool transform defaults to satisfy malformed tool config tests; security(vault): guard JSONFileVault watcher when no vault file provided to prevent chokidar errors\n\n- Add null checks before file watching\n- Add temperature and top_p to Responses API body when provided\n- Preserve undefined shapes in ChatCompletions transform for error-case parity\n- All affected core OpenAI unit tests pass locallySigned-off-by: Kavish Shah <kavishshah2005@gmail.com>
@coderabbitai
Copy link

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the.coderabbit.yaml file in this repository. To trigger a single review, invoke the@coderabbitai review command.

You can disable this status message by setting thereviews.review_status tofalse in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment@coderabbitai help to get the list of available commands and usage tips.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@thekavishshah

[8]ページ先頭

©2009-2025 Movatter.jp