- Notifications
You must be signed in to change notification settings - Fork186
core(openai): Responses API adds temperature/top_p; guard vault watcher when file not set; align ChatCompletions tool transform defaults#128
Open
thekavishshah wants to merge 1 commit intoSmythOS:devfrom
Conversation
…letions tool transform defaults to satisfy malformed tool config tests; security(vault): guard JSONFileVault watcher when no vault file provided to prevent chokidar errors\n\n- Add null checks before file watching\n- Add temperature and top_p to Responses API body when provided\n- Preserve undefined shapes in ChatCompletions transform for error-case parity\n- All affected core OpenAI unit tests pass locallySigned-off-by: Kavish Shah <kavishshah2005@gmail.com>
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses three related issues:\n\n- OpenAI Responses API: include and when provided, matching ChatCompletions parity\n- ChatCompletions tools transform: preserve undefined defaults to satisfy malformed tool config error-case tests\n- Vault security: guard JSONFileVault watcher when no vault file path is configured to avoid chokidar runtime errors\n\nNotes:\n- All affected @smythos/core OpenAI unit tests pass locally\n- Single commit with DCO sign-off\n\nPlease let me know if you'd prefer separate PRs or additional test coverage.