- Notifications
You must be signed in to change notification settings - Fork196
Renders relationship objects even where's no data on included#276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
andersonmarcelino wants to merge1 commit intoSeyZ:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Roriz approved these changesNov 3, 2023
martinezguillaume commentedJun 13, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
this pr is highly needed & useful ! Is there any way to get it merged ? :) the file diff --git a/node_modules/jsonapi-serializer/lib/deserializer-utils.js b/node_modules/jsonapi-serializer/lib/deserializer-utils.jsindex 1265fd4..480ab81 100644--- a/node_modules/jsonapi-serializer/lib/deserializer-utils.js+++ b/node_modules/jsonapi-serializer/lib/deserializer-utils.js@@ -26,7 +26,7 @@ module.exports = function (jsonapi, data, opts) { function findIncluded(relationshipData, ancestry) { return new Promise(function (resolve) {- if (!jsonapi.included || !relationshipData) { resolve(null); }+ if (!relationshipData) { resolve(null); } var included = _find(jsonapi.included, { id: relationshipData.id,@@ -54,7 +54,7 @@ module.exports = function (jsonapi, data, opts) { resolve(_extend(attributes, relationships)); }); } else {- return resolve(null);+ return resolve({ id: relationshipData.id }); } }); } |
| if(!relationshipData){resolve(null);} | ||
| varincluded=_find(jsonapi.included,{ | ||
| varincluded=_find(jsonapi.included||[],{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this line is useless, you can call _find withnull orundefined 👍
martinezguillaume approved these changesJun 13, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Issue opened with the description of error:#253
When the deserializer receives a relationship without included data, they just ignore it, but sometimes, for performance uses, we just need the object id, and dont want to include the entire object on response data. This solution add an object with just an in on the output of deserializer.