Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: prefer ArrayPartitionStyle to preserve nesting structure#483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
DhairyaLGandhi wants to merge5 commits intoSciML:master
base:master
Choose a base branch
Loading
fromDhairyaLGandhi:dg/nest

Conversation

@DhairyaLGandhi
Copy link
Member

@DhairyaLGandhiDhairyaLGandhi commentedAug 21, 2025
edited
Loading

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular theSciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Ref#480

Add any other context about the problem here.

@ChrisRackauckas
Copy link
Member

Rebase for the tests?

@DhairyaLGandhi
Copy link
MemberAuthor

I have a question, what purpose does nesting ARrayPartitions serve and is that a structure that should be maintained? Because we could always flatten the paritions of the children as partitions of the parent directly right?
The sizes would need to be consistent of course.

@kellertuer
Copy link

kellertuer commentedAug 25, 2025
edited
Loading

For the context in#480 originally comes from, no please do not flatten the structure: In that setting we handle elements on a product manifold with ArrayPartitions. We do not have to dive into manifolds, set products are enough:

Imagine you are on a set$A(n) = \mathbb R^n \times \mathcal P(n)$, i.e. the set of tuples where the first component is a vector and the second is a symmetric, positive definite matrix.
For the simplest case consider$B = A(2) \times A(3)$ so tuples where the first is the 2D case from before, the second the 3D case.
Surely any$b \in B$ should be an array partition of array partitions, i.e. have two entries, each of which is an array partition.

If you internally handle that in a fancy-flattened way, sure, feel free ;) But on the outer I would like to access the first or second element ofb without having to thing about what these two elements are.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DhairyaLGandhi@ChrisRackauckas@kellertuer

[8]ページ先頭

©2009-2025 Movatter.jp