Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork120
Update documentation ofsave_start andsave_end#977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| as the final timepoint. This setting is overridden by other saving settings when set to | ||
| `false`. Defaults to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That shouldn't be the case.save_start andsave_end should be concrete and overriding in that sense. The solution here isn't to document a current bug.
ArneBouillonDec 17, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That's on me then; I interpretedSciML/OrdinaryDiffEq.jl#1842 (comment) to mean that the current behaviour should be documented. I'll mark both PRs for this as WIP.
Let's discuss this in more detail inthat issue to keep everything centralised.
FixesSciML/OrdinaryDiffEq.jl#1842
A proposal to clarify the complicated current behaviour of
save_startandsave_endin the documentation.