Commitf457a01

committed

log tutorial start

Signed-off-by: shmck <shawn.j.mckay@gmail.com>

1 parent2d96577 commitf457a01Copy full SHA for f457a01

File tree

+16

-4

lines changed

+16

-4

lines changed

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@ import { exec } from '../services/node'`
`20`	`20`	`import{WORKSPACE_ROOT,TUTORIAL_URL}from'../environment'`
`21`	`21`	`importresetfrom'../services/reset'`
`22`	`22`	`importgetLastCommitHashfrom'../services/reset/lastHash'`
	`23`	`+import{onEvent}from'../services/telemetry'`
`23`	`24`
`24`	`25`	`constreadFileAsync=promisify(readFile)`
`25`	`26`
`@@ -128,6 +129,12 @@ class Channel implements Channel {`
`128`	`129`	`try{`
`129`	`130`	`constdata:TT.Tutorial=action.payload.tutorial`
`130`	`131`
	`132`	`+onEvent('tutorial_start',{`
	`133`	`+tutorial_id:data.id,`
	`134`	`+tutorial_version:data.version,`
	`135`	`+tutorial_title:data.summary.title,`
	`136`	`+})`
	`137`	`+`
`131`	`138`	`// validate extension version`
`132`	`139`	`constexpectedAppVersion=data.config?.appVersions?.vscode`
`133`	`140`	`if(expectedAppVersion){`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -23,13 +23,17 @@ class Editor {`
`23`	`23`	`workspaceState:this.vscodeExt.workspaceState,`
`24`	`24`	`})`
`25`	`25`
	`26`	`+constsubscribe=(sub:any)=>{`
	`27`	`+this.vscodeExt.subscriptions.push(sub)`
	`28`	`+}`
	`29`	`+`
`26`	`30`	`// register commands`
`27`	`31`	`for(constcmdincommands){`
`28`	`32`	`constcommand:vscode.Disposable=vscode.commands.registerCommand(cmd,commands[cmd])`
`29`		`-this.vscodeExt.subscriptions.push(command)`
	`33`	`+subscribe(command)`
`30`	`34`	`}`
`31`	`35`
`32`		`-telemetry.activate()`
	`36`	`+telemetry.activate(subscribe)`
`33`	`37`	`}`
`34`	`38`	`publicdeactivate=():void=>{`
`35`	`39`	`// cleanup subscriptions/tasks`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ export const EXTENSION_ID = 'coderoad'`
`8`	`8`	`// Node env`
`9`	`9`	`exporttypeEnv='test'\|'local'\|'development'\|'production'`
`10`	`10`	`//@ts-ignore`
`11`		`-exportconstNODE_ENV:Env=process.env.NODE_ENV\|\|'production'`
	`11`	`+exportconstNODE_ENV:Env=process.env.NODE_ENV\|\|'development'`
`12`	`12`
`13`	`13`	`// toggle logging in development`
`14`	`14`	`exportconstLOG=false`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -17,9 +17,10 @@ interface Measurements {`
`17`	`17`
`18`	`18`	`letreporter:any`
`19`	`19`
`20`		`-exportconstactivate=():void=>{`
	`20`	`+exportconstactivate=(subscribeFn:(reporter:any)=>void):void=>{`
`21`	`21`	`if(NODE_ENV==='production'){`
`22`	`22`	`reporter=newTelemetryReporter(EXTENSION_ID,VERSION,INSTRUMENTATION_KEY)`
	`23`	`+subscribeFn(reporter)`
`23`	`24`	`}`
`24`	`25`	`}`
`25`	`26`

Comments

(0)