- Notifications
You must be signed in to change notification settings - Fork714
Remove problematic content slicing in test output parsing#402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
john-b-yang commentedMay 22, 2025
Hmm I understand the problem, thanks for noticing it. But I probably wouldn't prefer this be the default behavior. Perhaps we can condition this statement on whether Modal eval is being used. It's not a big difference I guess, but the reason this statement exists is to make sure text not related to testing output is ignored. |
ryanhoangt commentedMay 27, 2025
@john-b-yang that makes sense, I modified the code to skip the content slicing on Modal only, could you help take another look? |
ryanhoangt commentedJun 16, 2025
Hi@john-b-yang, just a friendly ping on this PR - please let me know if there's anything I can clarify or improve. Thanks! |
neubig commentedAug 29, 2025
Hi@john-b-yang and/or@klieret, would it be possible to get this merged? We're currently having to work off a branch of swe-bench and it's causing us logistics issues at the moment. Thanks a lot for the consideration! |
Reference Issues/PRs
Fix#377
What does this implement/fix? Explain your changes.
When running patch eval on Modal, I see that for some instances, the content of test output files being captured are out of order, which causes the test summary to fall outside the
>>>>> Start Test Outputand>>>>> End Test Outputmarkers. I attached a sample log file below.test_output_astropy__astropy-12907.txt
This PR removes the content slicing line and uses the whole file content for parsing.
Any other comments?
🧡 Thanks for contributing!