Providers/Resgrid.Providers.Messaging/NovuProvider.cs (2)

198-201:User APNS provider ID appears incorrect (uses Unit provider ID).

UpdateUserSubscriberApns passesChatConfig.NovuUnitApnsProviderId for a user subscriber. GivenUpdateUserSubscriberFcm usesNovuResponderFcmProviderId, the APNS counterpart should likely be the responder/user APNS provider ID, not the unit one. This likely mis-associates user devices to the unit integration in Novu.

Apply this diff ifChatConfig.NovuResponderApnsProviderId exists:

-      return await UpdateSubscriberApns($"{code}_User_{userId}", token, ChatConfig.NovuUnitApnsProviderId);+      return await UpdateSubscriberApns($"{code}_User_{userId}", token, ChatConfig.NovuResponderApnsProviderId);

If the responder APNS provider ID isn’t defined in ChatConfig, please confirm the intended value and adjust accordingly.

---

320-349:Restore iOS .caf sound files in NovuProvider and honor enableCustomSounds

The other providers still emit.caf for iOS while NovuProvider now hard-codes only.wav, which will break any iOS app bundling.caf assets. Also, theenableCustomSounds flag is passed into your public API but never used—consider falling back to a generic “beep” when it’s disabled.

• File: Providers/Resgrid.Providers.Messaging/NovuProvider.cs
Method: GetSoundFileNameFromType(Platforms platform, string type)

Diff suggestion:

     private string GetSoundFileNameFromType(Platforms platform, string type)     {+        // iOS assets are .caf; others use .wav+        var ext = platform == Platforms.iOS ? ".caf" : ".wav";          if (type == ((int)PushSoundTypes.CallEmergency).ToString())         {-            return "callemergency.wav";+            return "callemergency" + ext;         }         else if (type == ((int)PushSoundTypes.CallHigh).ToString())         {-            return "callhigh.wav";+            return "callhigh" + ext;         }         else if (type == ((int)PushSoundTypes.CallMedium).ToString())         {-            return "callmedium.wav";+            return "callmedium" + ext;         }         else if (type == ((int)PushSoundTypes.CallLow).ToString())         {-            return "calllow.wav";+            return "calllow" + ext;         }         else if (type == ((int)PushSoundTypes.Notifiation).ToString())         {-            return "notification.wav";+            return "notification" + ext;         }         else if (type == ((int)PushSoundTypes.Message).ToString())         {-            return "message.wav";+            return "message" + ext;         }         else         {-            return $"{type}.wav";+            return $"{type}{ext}";         }     }

Also, consider updating this method signature to accept the existingenableCustomSounds parameter and, when it’sfalse, return a generic"beep" sound (e.g."beep.caf" on iOS,"beep.wav" elsewhere).

Providers/Resgrid.Providers.Messaging/NovuProvider.cs (3)

352-359:Unused helper (FormatForAndroidNativePush) and stale Android sound handling.

This helper appears unused after the refactor and the new FCM overrides no longer set a custom sound for Android (only defaultSound). If custom Android sounds are desired when enableCustomSounds is true, this path needs to be wired back in; otherwise, remove the unused helper to reduce dead code.

---

377-467:Legacy payload builders likely dead code; consider removal or alignment.

CreateAndroidNotification and CreateAppleNotification seem to be legacy builders that aren’t used after moving to Novu “overrides”. Keeping both shapes increases drift and confusion.

• Either remove these builders if definitively unused, or
• Reuse them to assemble the override payload to ensure one source of truth for fields, sound, priorities, and category mapping.

---

21-58:Prefer IHttpClientFactory or a shared HttpClient for resiliency and testability.

Multiple methods new-up HttpClient and set common headers. Consider injecting IHttpClientFactory (or an HttpClient) and centralizing common headers to:

• Avoid socket exhaustion from frequent instantiation
• Improve testability (mock handlers)
• Consolidate auth/idempotency header logic

I can draft a minimal refactor using IHttpClientFactory if desired.

Core/Resgrid.Services/CommunicationService.cs (1)

205-213:Awaiting the voice call is correct; consider handling the boolean result.

You’re now awaiting the async voice call, but discarding the boolean. If the provider indicates failure (returns false), you could log or take fallback action.

Example:

• var success = await _outboundVoiceProvider.CommunicateCallAsync(...);
• if (!success) Logging.LogWarning("Outbound voice call failed for {UserId}/{CallId}");

Providers/Resgrid.Providers.Number/OutboundVoiceProvider.cs (2)

42-44:Consider basing success on Twilio response and catching exceptions here.

Right now the method returns true immediately after CreateAsync. If Twilio returns an error (exception thrown) it will bubble up; if it succeeds but Twilio marks the call failed quickly, you still return true. Optionally:

• Wrap Twilio CreateAsync in try/catch here and return false on exception, logging the error.
• Check phoneCall.Status or ErrorCode to decide success (best-effort).

I can provide a diff adding try/catch and minimal status validation if you want stricter semantics for the boolean.

Also applies to: 56-58

---

33-59:Minor duplication between mobile/home call paths.

The two branches differ only by the target number accessor. Extracting a small local function to create the call reduces duplication and centralizes options assembly.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Providers/Resgrid.Providers.Messaging/NovuProvider.cs (1)

320-349:Restore platform‐specific sound file extensions in NovuProvider.GetSoundFileNameFromType

The current implementation always returns “.wav”, which will break iOS custom sounds (other providers use “.caf” on iOS and “.wav”/“.mp3” on Android). Update as follows:

• File: Providers/Resgrid.Providers.Messaging/NovuProvider.cs
Method: GetSoundFileNameFromType (lines 320–349)

Apply this diff to match NotificationProvider/UnitNotificationProvider mapping:

   private string GetSoundFileNameFromType(Platforms platform, string type)   {-    if (type == ((int)PushSoundTypes.CallEmergency).ToString())-    {-      return "callemergency.wav";-    }+    if (type == ((int)PushSoundTypes.CallEmergency).ToString())+    {+      if (platform == Platforms.iOS) return "callemergency.caf";+      return "callemergency.wav";+    }     else if (type == ((int)PushSoundTypes.CallHigh).ToString())     {-      return "callhigh.wav";+      if (platform == Platforms.iOS) return "callhigh.caf";+      return "callhigh.mp3";     }     else if (type == ((int)PushSoundTypes.CallMedium).ToString())     {-      return "callmedium.wav";+      if (platform == Platforms.iOS) return "callmedium.caf";+      return "callmedium.mp3";     }     else if (type == ((int)PushSoundTypes.CallLow).ToString())     {-      return "calllow.wav";+      if (platform == Platforms.iOS) return "calllow.caf";+      return "calllow.mp3";     }     else if (type == ((int)PushSoundTypes.Notifiation).ToString())     {-      return "notification.wav";+      if (platform == Platforms.iOS) return "notification.caf";+      return "notification.mp3";     }     else if (type == ((int)PushSoundTypes.Message).ToString())     {-      return "message.wav";+      if (platform == Platforms.iOS) return "message.caf";+      return "message.mp3";     }     else     {-      return $"{type}.wav";+      if (platform == Platforms.iOS) return $"{type}.caf";+      return $"{type}.mp3";     }   }

If your iOS bundle only contains “.wav” assets, adjust the mapping accordingly to avoid missing sound files.

Providers/Resgrid.Providers.Messaging/NovuProvider.cs (2)

4-4:Remove unused using RabbitMQ.Client

RabbitMQ.Client isn’t referenced in this file. Drop the import to keep things tidy.

Apply this diff:

-using RabbitMQ.Client;

---

263-267:enableCustomSounds parameter is ignored for APNS

The SendNotification signature includes enableCustomSounds, but APNS sound is always set to a custom file. If you intended to honor the flag (e.g., use system default when false), gate the sound block accordingly.

Apply this diff to conditionally include the sound block:

-                sound = new-                {-                  name = GetSoundFileNameFromType(Platforms.iOS, type),-                  critical = channelName == "calls" ? 1 : 0,-                  volume = 1.0f-                },+                sound = enableCustomSounds ? new+                {+                  name = GetSoundFileNameFromType(Platforms.iOS, type),+                  critical = channelName == "calls" ? 1 : 0,+                  volume = 1.0f+                } : null,

Also set NullValueHandling.Ignore to avoid emitting null sound.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.