Web/Resgrid.Web/Views/Account/LogOn.cshtml (1)

97-97:Rename ‘SetLanugage’ to ‘SetLanguage’

The action and all its references are misspelled as “SetLanugage.” To prevent confusion and future bugs, rename the action method and update the view bindings:

• AccountController (Web/Resgrid.Web/Controllers/AccountController.cs, line 507)
– Change
public IActionResult SetLanugage(string culture, string returnUrl)
– To
public IActionResult SetLanguage(string culture, string returnUrl)

• LogOn.cshtml (Web/Resgrid.Web/Views/Account/LogOn.cshtml, line 97)
– Change
<form … asp-action="SetLanugage" …>
– To
<form … asp-action="SetLanguage" …>

• _TopNavbar.cshtml (Web/Resgrid.Web/Areas/User/Views/Shared/_TopNavbar.cshtml, line 53)
– Change
<form … asp-action="SetLanugage" …>
– To
<form … asp-action="SetLanguage" …>

Ensure any route tests or JavaScript calls referencing this endpoint are updated accordingly.

Web/Resgrid.Web.Services/Controllers/v4/PersonnelStaffingController.cs (2)

75-83:Bug: Using current user instead of requested user when loading state

GetLastUserStateByUserIdAsync is called withUserId (the caller) instead of theuserId parameter after it’s normalized. This returns the wrong person’s staffing for requests querying another user.

Fix the call to use theuserId variable:

- var userState = await _userStateService.GetLastUserStateByUserIdAsync(UserId);+ var userState = await _userStateService.GetLastUserStateByUserIdAsync(userId);

---

187-191:Harden parsing of input.Type before looping over UserIds

To prevent aFormatException (e.g. wheninput.Type is whitespace), parse once up‐front withint.TryParse and return a 400 if invalid. Then use the parsed value in bothCreateUserState calls:

• File: Web/Resgrid.Web.Services/Controllers/v4/PersonnelStaffingController.cs
Lines: around 187–191

Suggested diff:

-            // inside SavePersonsStaffings, before looping-            List<string> logIds = new List<string>();+            // Validate and parse Type once+            if (!int.TryParse(input.Type, out var typeVal))+                return BadRequest("`Type` must be a valid integer.");+            var logIds = new List<string>();             foreach (var userId in input.UserIds)             {@@-                if (String.IsNullOrWhiteSpace(input.Note))-                    savedState = await _userStateService.CreateUserState(userToSetStatusFor.UserId, DepartmentId, int.Parse(input.Type), cancellationToken);-                else-                    savedState = await _userStateService.CreateUserState(userToSetStatusFor.UserId, DepartmentId, int.Parse(input.Type), input.Note, cancellationToken);+                if (string.IsNullOrWhiteSpace(input.Note))+                    savedState = await _userStateService.CreateUserState(userToSetStatusFor.UserId, DepartmentId, typeVal, cancellationToken);+                else+                    savedState = await _userStateService.CreateUserState(userToSetStatusFor.UserId, DepartmentId, typeVal, input.Note, cancellationToken);

Providers/Resgrid.Providers.Bus.Rabbit/RabbitInboundQueueProvider.cs (1)

579-582:Header parsing is brittle; Rabbit header values are often byte[] or long

ea.BasicProperties.Headers values are AMQP field tables and commonly arrive as byte[] or integer types. To avoid parse errors (e.g., "System.Byte[]" string), handle multiple types.

Apply this diff:

-int currentDeliveryCount = 0;--if (ea.BasicProperties != null && ea.BasicProperties.Headers != null && ea.BasicProperties.Headers.Count > 0 &&-  ea.BasicProperties.Headers.ContainsKey("x-redelivered-count"))-  currentDeliveryCount = int.Parse(ea.BasicProperties.Headers["x-redelivered-count"].ToString());+int currentDeliveryCount = 0;+if (ea.BasicProperties?.Headers != null &&+    ea.BasicProperties.Headers.TryGetValue("x-redelivered-count", out var hdrVal))+{+  switch (hdrVal)+  {+    case byte b: currentDeliveryCount = b; break;+    case sbyte sb: currentDeliveryCount = sb; break;+    case short s: currentDeliveryCount = s; break;+    case int i: currentDeliveryCount = i; break;+    case long l: currentDeliveryCount = (int)l; break;+    case byte[] bytes:+      if (int.TryParse(Encoding.UTF8.GetString(bytes), out var parsedBytes))+        currentDeliveryCount = parsedBytes;+      break;+    default:+      int.TryParse(hdrVal?.ToString(), out currentDeliveryCount);+      break;+  }+}

Web/Resgrid.Web/wwwroot/js/ng/vendor.js (1)

124644-124647:No-op async handler registered on Reconnected

This is an async no-op: function* () {}. Consider omitting the handler to reduce noise, unless used as a future hook.

Web/Resgrid.Web/Views/Account/Register.cshtml (2)

120-120:Possible typo in localization key: "Resgister".

The button uses@localizer["Resgister"]. If this is a misspelling, update to@localizer["Register"] and the corresponding resource keys. If “Resgister” is the intentional key in your resource files, ignore this.

---

94-94:Invalid CSS value: vertical-align: central;

“central” isn’t a valid value for vertical-align, and vertical-align doesn’t apply to block-level elements in this context. Consider removing it or using a flexbox layout for the label/select alignment.

Core/Resgrid.Model/DepartmentSettingTypes.cs (1)

39-39:Enum value added correctly; consider documenting the setting intent

PersonnelOnUnitSetUnitStatus = 35 is consistent with sequencing. Consider adding an XML summary to capture the behavior (gates creating unit-linked action logs and optionally personnel status updates).

Web/Resgrid.Web.Services/Controllers/v4/PersonnelStaffingController.cs (1)

71-71:Rename the action method to the correct spelling

The action name is still misspelled (GetCurrentStatffing). Rename the method to reduce confusion and improve API docs, while keeping both route attributes for compatibility.

- public async Task<ActionResult<GetCurrentStaffingResult>> GetCurrentStatffing(string userId)+ public async Task<ActionResult<GetCurrentStaffingResult>> GetCurrentStaffing(string userId)

Core/Resgrid.Model/ActionLog.cs (1)

54-59:Persisting Unit linkage: consider constraining UnitName length and indexing strategy

Adding UnitStateId and UnitName looks good. Recommend:

• Add a [MaxLength] constraint on UnitName to match expected lengths and avoid unbounded strings in SQL (e.g., 128–256 chars).
• If UnitName will be searched/filtered, consider adding an index at the DB level in the migration.

Example annotation:

 [ProtoMember(13)]-public string UnitName { get; set; }+[MaxLength(256)]+public string UnitName { get; set; }

If you’d prefer a different max length, I can update the migration(s) accordingly.

Providers/Resgrid.Providers.MigrationsPg/Migrations/M0035_UpdatingContactsTableAgain.cs (1)

9-17:Empty migration body with non-empty name/number

This no-op migration upgrades the version but does nothing. If intentional (to reconcile numbering across providers), add a brief comment explaining why to avoid confusion; otherwise, either implement the intended change or remove this migration.

Example:

// Intentionally left blank to align migration numbering across providers.

Providers/Resgrid.Providers.Bus.Rabbit/RabbitInboundQueueProvider.cs (1)

597-598:Consider excluding raw exception messages from headers

"x-previous-error" may leak sensitive info to consumers/logs. Prefer an error code or truncated/sanitized message.

Apply this diff to reduce exposure:

-props.Headers.Add("x-previous-error", mex.Message);+props.Headers.Add("x-previous-error", string.IsNullOrWhiteSpace(mex.Message) ? "UnhandledError" : mex.Message.Substring(0, Math.Min(256, mex.Message.Length)));

Or use a known error code map.

Providers/Resgrid.Providers.MigrationsPg/Migrations/M0036_AddingUnitStateToActionLogs.cs (1)

11-12:Nit: avoid repeated ToLower() calls on identical literals.

Minor readability refactor: store the normalized identifiers in locals to avoid repetition.

-Alter.Table("ActionLogs".ToLower()).AddColumn("UnitStateId".ToLower()).AsInt32().Nullable();-Alter.Table("ActionLogs".ToLower()).AddColumn("UnitName".ToLower()).AsCustom("citext").Nullable();+var table = "actionlogs";+Alter.Table(table).AddColumn("unitstateid").AsInt32().Nullable();+Alter.Table(table).AddColumn("unitname").AsCustom("citext").Nullable();

Web/Resgrid.Web.Services/Resgrid.Web.Services.xml (1)

3978-3984:Fix method XML docs: wrong summary and missing parameter.

The summary refers to “current user”, but this is UnitStatusController.SaveUnitStatus; it should describe saving a unit’s status. Also, the new CancellationToken parameter lacks documentation, and the param name/type reference says “StatusInput” instead of “UnitStatusInput”.

Proposed doc correction:

-        <member name="M:Resgrid.Web.Services.Controllers.v4.UnitStatusController.SaveUnitStatus(Resgrid.Web.Services.Models.v4.UnitStatus.UnitStatusInput,System.Threading.CancellationToken)">-            <summary>-            Sets the status/action for the current user.-            </summary>-            <param name="statusInput">StatusInput object with the Status/Action to set.</param>-            <returns>Returns HttpStatusCode Created if successful, BadRequest otherwise.</returns>-        </member>+        <member name="M:Resgrid.Web.Services.Controllers.v4.UnitStatusController.SaveUnitStatus(Resgrid.Web.Services.Models.v4.UnitStatus.UnitStatusInput,System.Threading.CancellationToken)">+            <summary>+            Sets the status/state for the specified unit.+            </summary>+            <param name="statusInput">UnitStatusInput object with the state to set.</param>+            <param name="cancellationToken">The cancellation token that can be used by other objects or threads to receive notice of cancellation.</param>+            <returns>Returns HttpStatusCode Created if successful, BadRequest otherwise.</returns>+        </member>

Core/Resgrid.Config/TelemetryConfig.cs (1)

19-26:Clarify multi-client analytics key selection and avoid dual source of truth.

• GetAnalyticsKey() always returns AptabaseWebApiKey for Aptabase. You added multiple Aptabase keys (Services/Responder/Unit/BigBoard/Dispatch), but they’re unused here. If GetConfig serves multiple client apps, this may leak the wrong key. Consider a keyed selector, e.g., GetAnalyticsKeyFor(string client).
• Exporter (string) and ExporterType (enum) can drift. Provide a single setter to keep them in sync.

Suggested additions:

 public static string GetAnalyticsKey() { if (ExporterType == TelemetryExporters.PostHog) return PostHogApiKey; else if (ExporterType == TelemetryExporters.Aptabase) return AptabaseWebApiKey; return string.Empty; }++// Optional: centralize host selection alongside key selection+public static string GetAnalyticsHost() =>+ExporterType == TelemetryExporters.PostHog ? PostHogUrl :+ExporterType == TelemetryExporters.Aptabase ? AptabaseUrl : string.Empty;++// Optional: keep Exporter and ExporterType in sync+public static void SetExporter(string exporter)+{+Exporter = exporter ?? string.Empty;+switch (exporter?.Trim().ToLowerInvariant())+{+case "posthog": ExporterType = TelemetryExporters.PostHog; break;+case "aptabase": ExporterType = TelemetryExporters.Aptabase; break;+default: ExporterType = TelemetryExporters.None; break;+}+}

Alternatively, extend GetAnalyticsKey(client) to map Aptabase keys per client (web/services/responder/unit/bigboard/dispatch).

Core/Resgrid.Services/DepartmentSettingsService.cs (1)

718-726:Consider caching this hot-path setting and invalidate on updates

This flag will be checked on SaveUnitStatus requests; adding caching will reduce DB load. Also ensure cache invalidation when the setting changes.

Apply this diff to introduce caching for the getter:

-public async Task<bool> GetPersonnelOnUnitSetUnitStatusAsync(int departmentId)-{-var settingValue = await GetSettingByDepartmentIdType(departmentId, DepartmentSettingTypes.PersonnelOnUnitSetUnitStatus);--if (settingValue != null)-return bool.Parse(settingValue.Setting);--return false;-}+public async Task<bool> GetPersonnelOnUnitSetUnitStatusAsync(int departmentId)+{+async Task<string> getSetting()+{+var s = await GetSettingByDepartmentIdType(departmentId, DepartmentSettingTypes.PersonnelOnUnitSetUnitStatus);+return s?.Setting ?? "false";+}++if (Config.SystemBehaviorConfig.CacheEnabled)+{+var cachedValue = await _cacheProvider.RetrieveAsync<string>(+string.Format(PersonnelOnUnitSetUnitStatusCacheKey, departmentId),+getSetting,+LongCacheLength);+return bool.Parse(cachedValue);+}++return bool.Parse(await getSetting());+}

Add these outside the selected range:

// Near other cache keys at the topprivatestaticstringPersonnelOnUnitSetUnitStatusCacheKey="DSetOnUnitSetUnitStatus_{0}";

And invalidate on update in SaveOrUpdateSettingAsync’s switch:

caseDepartmentSettingTypes.PersonnelOnUnitSetUnitStatus:_cacheProvider.Remove(string.Format(PersonnelOnUnitSetUnitStatusCacheKey,departmentId));break;

Web/Resgrid.Web.Services/Controllers/v4/CallFilesController.cs (2)

128-130:Good defensive validation, but consider logging or monitoring.

The validation correctly prevents processing when attachment data is invalid. However, since this is a change in behavior (previously it might have thrown an exception downstream), consider adding logging to track when these conditions occur.

 if (String.IsNullOrWhiteSpace(attachment.FileName) || attachment.Data == null || attachment.Data.Length == 0)+{+    Logging.LogWarning($"GetFile: Invalid attachment data for attachment ID {id} - FileName: {!String.IsNullOrWhiteSpace(attachment.FileName)}, DataLength: {attachment.Data?.Length ?? 0}");     return NotFound();+}

---

171-173:Inconsistent validation pattern with GetFile method.

This method has the same validation asGetFile, which is good. However, the validation logic is duplicated. Consider extracting this to a helper method to maintain DRY principles.

Add a private helper method to reduce duplication:

privateboolIsValidAttachment(CallAttachmentattachment){return!String.IsNullOrWhiteSpace(attachment?.FileName)&&attachment.Data!=null&&attachment.Data.Length>0;}

Then use it in both methods:

-if (String.IsNullOrWhiteSpace(attachment.FileName) || attachment.Data == null || attachment.Data.Length == 0)+if (!IsValidAttachment(attachment))     return NotFound();

Web/Resgrid.Web.Services/Controllers/TwilioController.cs (5)

478-488:Duplicate Gather blocks may confuse callers

Creating two identical Gather blocks in sequence could lead to poor user experience. If the user doesn't respond to the first prompt, they'll hear the exact same prompt again, which may be confusing. Consider adding a variation or escalation in the second prompt.

 for (int repeat = 0; repeat < 2; repeat++) {     var gatherResponse1 = new Gather(numDigits: 1, action: new Uri(string.Format("{0}/api/Twilio/VoiceCallAction?userId={1}&callId={2}", Config.SystemBehaviorConfig.ResgridApiBaseUrl, userId, callId)), method: "GET")     {         BargeIn = true     };-    gatherResponse1.Append(new Say(sb1.ToString()));+    if (repeat == 0)+        gatherResponse1.Append(new Say(sb1.ToString()));+    else+        gatherResponse1.Append(new Say("I didn't catch that. " + sb1.ToString()));     gatherResponse1.Append(playResponse);     response.Append(gatherResponse1); }

---

537-545:Duplicate Gather blocks may confuse callers

Similar to the previous comment, having two identical prompts in sequence without variation could confuse users who don't respond to the first prompt.

 for (int repeat = 0; repeat < 2; repeat++) {     var gatherResponse = new Gather(numDigits: 1, action: new Uri(string.Format("{0}/api/Twilio/VoiceCallAction?userId={1}&callId={2}", Config.SystemBehaviorConfig.ResgridApiBaseUrl, userId, callId)), method: "GET")     {         BargeIn = true     };-    gatherResponse.Append(new Say(sb.ToString()));+    if (repeat == 0)+        gatherResponse.Append(new Say(sb.ToString()));+    else+        gatherResponse.Append(new Say("I didn't catch that. " + sb.ToString()));     response.Append(gatherResponse); }

---

638-646:Duplicate Gather blocks may confuse callers

The main menu also uses duplicate identical prompts. Consider adding variation for better user experience.

 for (int repeat = 0; repeat < 2; repeat++) {     var gatherResponse = new Gather(numDigits: 1, action: new Uri(string.Format("{0}/api/Twilio/InboundVoiceAction?userId={1}", Config.SystemBehaviorConfig.ResgridApiBaseUrl, profile.UserId)), method: "GET")     {         BargeIn = true     };-    gatherResponse.Append(new Say(sb.ToString()));+    if (repeat == 0)+        gatherResponse.Append(new Say(sb.ToString()));+    else+        gatherResponse.Append(new Say("I didn't catch that. " + sb.ToString()));     response.Append(gatherResponse); }

---

832-836:Duplicate Gather blocks in dynamic menu generation

The pattern of duplicate identical Gather blocks continues here. Consider adding variation for consistency with other suggested improvements.

 for (int repeat = 0; repeat < 2; repeat++) {-    gatherResponse.Append(new Say(sb.ToString()));+    if (repeat == 0)+        gatherResponse.Append(new Say(sb.ToString()));+    else+        gatherResponse.Append(new Say("I didn't catch that. " + sb.ToString()));     response.Append(gatherResponse); }

---

781-822:Consider extracting option building logic

The status and staffing option building logic is very similar. Consider extracting this into a helper method to reduce duplication and improve maintainability.

Would you like me to generate a helper method that consolidates the option building logic for both status and staffing selections?

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Web/Resgrid.Web/Views/Account/CompleteInvite.cshtml (3)

41-43:Add rel="noopener noreferrer" to external links opened in a new tab

Prevents window.opener vulnerabilities and improves performance when using.

-                    @localizer["SignUpTerms1"] Resgrid's <a asp-controller="Public" asp-action="Terms">@localizer["TermsOfUse"]</a> &-                    <a asp-controller="Public" asp-action="Privacy">@localizer["PrivacyPolicy"]</a>+                    @localizer["SignUpTerms1"] Resgrid's <a asp-controller="Public" asp-action="Terms" rel="noopener noreferrer">@localizer["TermsOfUse"]</a> &+                    <a asp-controller="Public" asp-action="Privacy" rel="noopener noreferrer">@localizer["PrivacyPolicy"]</a>

---

26-26:Add alt text to the logo for accessibility

Images used as branding should have an alt description so screen readers convey context.

-                    <a href="@Resgrid.Config.UrlsConfig.HomeUrl"><img src="~/images/Resgrid_JustText.png" /></a>+                    <a href="@Resgrid.Config.UrlsConfig.HomeUrl"><img src="~/images/Resgrid_JustText.png" alt="Resgrid" /></a>

---

80-80:Fix typo “Resgister” → “Register” in views and resource files

The key “Resgister” is consistently used in two Razor views and two.resx files—this will render the typo at runtime. Please update the key and its value as follows:

• Web/Resgrid.Web/Views/Account/CompleteInvite.cshtml (line 80)
Change
@localizer["Resgister"]
to
@localizer["Register"]

• Web/Resgrid.Web/Views/Account/Register.cshtml (line 120)
Change
@localizer["Resgister"]
to
@localizer["Register"]

• Core/Resgrid.Localization/Account/Login.en.resx (≈lines 243–244)
– Rename
<data name="Resgister" …> →<data name="Register" …>
– Update
<value>Resgister</value> →<value>Register</value>

• Core/Resgrid.Localization/Account/Login.es.resx (≈line 243)
– Rename key as above
– Update the<value> to the correct Spanish translation (e.g. “Registrarse”) per your localization guidelines

Suggested diff:

--- before                                       --- after- @localizer["Resgister"]                       + @localizer["Register"]- <data name="Resgister" xml:space="preserve">  + <data name="Register" xml:space="preserve">-   <value>Resgister</value>                    +   <value>Register</value>  (or proper Spanish text)

Web/Resgrid.Web/Views/Account/CompleteInvite.cshtml (3)

94-96:Optional: match typography with the year using

To visually balance the left/right columns, wrap the company name in small text like the year column.

-            <div>-                Resgrid, LLC.-            </div>+            <div>+                <small>Resgrid, LLC.</small>+            </div>

---

101-101:Use HTML entity for the copyright symbol

Using © avoids encoding surprises across locales and editors.

-                <small>© @DateTime.Now.Year</small>+                <small>&copy; @DateTime.Now.Year</small>

---

51-52:Form/JS mismatch: IDs referenced in JS don’t exist; reCAPTCHA line should be guarded

The submit handler targets #registrationForm and #registerButton, but the markup lacks these IDs. Also, reCAPTCHA fields may not exist on this page; guard the code to avoid no-op confusion.

Apply these diffs:

Add IDs to form and button so the JS can bind and disable the button on submit:

-                    <form role="form" asp-controller="Account" asp-action="CompleteInvite" method="post">+                    <form role="form" asp-controller="Account" asp-action="CompleteInvite" method="post">...-                        <button type="submit">@localizer["Resgister"]</button>+                        <button type="submit">@localizer["Resgister"]</button>

Guard the reCAPTCHA assignment so it only runs if fields exist:

-              $(document).on('submit', '#registrationForm', function () {-                var crep = $('#g-recaptcha-response').val();-                $('#GoogleReCaptchaResponse').val(crep);+              $(document).on('submit', '#registrationForm', function () {+                var $crep = $('#g-recaptcha-response');+                if ($crep.length) {+                  $('#GoogleReCaptchaResponse').val($crep.val());+                }

If this page doesn’t use reCAPTCHA, consider removing those lines entirely.

Also applies to: 80-80, 117-120

Web/Resgrid.Web.Services/Controllers/TwilioController.cs (2)

630-637:Polish the IVR prompt phrasing and punctuation

Minor grammatical nit: standardize casing and insert commas to aid TTS clarity.

Apply this diff to refine the wording:

- sb.Append($@"Hello {profile.FirstName}, this is the Resgrid Automated Voice System for {department.Name}. Please select from the following options.-To list current active calls press 1,-To list current user statuses press 2,-To list current unit statuses press 3,-To list upcoming Calendar events press 4,-To list upcoming Shifts press 5,-To Set your current status press 6,-To set your current staffing level press 7");+ sb.Append($@"Hello {profile.FirstName}, this is the Resgrid automated voice system for {department.Name}. Please select from the following options.+To list current active calls, press 1.+To list current user statuses, press 2.+To list current unit statuses, press 3.+To list upcoming calendar events, press 4.+To list upcoming shifts, press 5.+To set your current status, press 6.+To set your current staffing level, press 7.");

---

709-715:Risk of overly long TTS prompts; consider limiting or chunking results

Reading all calls, all users with status/staffing, and all units can produce extremely long prompts, hurting UX and risking Twilio timeouts.

Consider:

• Limit items (e.g., top 10) and end with “For more, use the mobile app or website.”
• Or paginate/chunk and redirect to a follow-up menu.
• For calls/units, summarize counts and only read brief highlights (e.g., counts by priority/status) to reduce verbosity.

Also applies to: 727-737, 748-756

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Web/Resgrid.Web.Services/Models/v3/BigBoard/BigBoardModel.cs (1)

291-297:Guard against null roles to avoid NRE

roles can be null; wrap the loop to prevent a runtime exception.

Apply this diff:

-foreach (var role in roles)-{-if (newRoles.Length > 0)-newRoles.Append(", " + role.Name);-else-newRoles.Append(role.Name);-}+if (roles != null)+{+foreach (var role in roles)+{+if (newRoles.Length > 0)+newRoles.Append(", " + role.Name);+else+newRoles.Append(role.Name);+}+}

Web/Resgrid.Web/Views/Account/CompleteInvite.cshtml (2)

106-128:JavaScript selectors reference non-existent element IDs (form/button)

The script binds to#registrationForm and disables#registerButton on submit, but:

• The<form> at Line 51 has no id.
• The submit<button> at Line 80 has no id.

Result: no handler is attached; the disable-on-submit safeguard never runs.

Add stable IDs to match the selectors (or update the selectors). Suggested fix:

@@-                    <form role="form" asp-controller="Account" asp-action="CompleteInvite" method="post">+                    <form role="form" asp-controller="Account" asp-action="CompleteInvite" method="post">@@-                        <button type="submit">@localizer["Resgister"]</button>+                        <button type="submit">@localizer["Resgister"]</button>

If you adopt the typo fix above, also update the button label accordingly.

---

80-80:Fix typo in localization key “Resgister” → “Register”

Update resource entries and cshtml references:

• Core/Resgrid.Localization/Account/Login.en.resx

  –  <data name="Resgister" xml:space="preserve">–    <value>Resgister</value>+  <data name="Register" xml:space="preserve">+    <value>Register</value>

• Core/Resgrid.Localization/Account/Login.es.resx

  –  <data name="Resgister" xml:space="preserve">–    <value>Registrarse</value>+  <data name="Register" xml:space="preserve">+    <value>Registrarse</value>

• Web/Resgrid.Web/Views/Account/Register.cshtml

  –<button type="submit">@localizer["Resgister"]</button>+<button type="submit">@localizer["Register"]</button>

• Web/Resgrid.Web/Views/Account/CompleteInvite.cshtml

  –<button type="submit">@localizer["Resgister"]</button>+<button type="submit">@localizer["Register"]</button>

Web/Resgrid.Web.Services/Models/v3/BigBoard/BigBoardModel.cs (1)

484-497:Add OnUnit to ActionTypes.ToCss() for consistency with new helper/state

Extend the local mapping so callers using CssExtensions also get the correct class for OnUnit.

Apply this diff:

 switch (type) { case ActionTypes.StandingBy: return ""; case ActionTypes.NotResponding: return "label-important"; case ActionTypes.Responding: return "label-success"; case ActionTypes.OnScene: return "label-inverse"; case ActionTypes.AvailableStation: return ""; case ActionTypes.RespondingToStation: return "label-success"; case ActionTypes.RespondingToScene: return "label-success";+case ActionTypes.OnUnit: return "label-success"; default: return ""; }

Web/Resgrid.Web.Services/Models/v3/BigBoard/BigBoardModel.cs (2)

249-253:Consider capturing coordinates for OnUnit (if present)

Other “responding” states persist GeoLocationData to map pins; if OnUnit actions can include coordinates, mirror that behavior for parity.

Apply this diff if OnUnit may include GeoLocationData:

-            statusCss = actionLog.GetActionCss();-            status = actionLog.GetActionText();+            statusCss = actionLog.GetActionCss();+            status = actionLog.GetActionText();+            if (!String.IsNullOrWhiteSpace(actionLog.GeoLocationData))+            {+              var cords = actionLog.GetCoordinates();+              latitude = cords.Latitude;+              longitude = cords.Longitude;+            }

---

299-317:Set CallNumber on the returned view model (currently unused property)

CallNumber is a property but isn’t populated. If intended for UI, assign it during initialization.

Apply this diff:

-DestinationType = destinationType+DestinationType = destinationType,+CallNumber = callNumber

Web/Resgrid.Web.Services/Controllers/TwilioController.cs (4)

689-691:Unnecessary variable initialization

ThegatherResponse variable is initialized tonull on line 690 but is conditionally assigned later. Consider initializing it only where needed to improve clarity.

 StringBuilder sb = new StringBuilder();-Gather gatherResponse = null;

---

871-879:Consider consolidating error handling logic

The error handling for invalid digits and empty input could be consolidated since they both redirect to the same endpoint with similar messages.

-else-{-    response.Say("Invalid status selection, goodbye.").Redirect(new Uri($"{Config.SystemBehaviorConfig.ResgridApiBaseUrl}/api/Twilio/InboundVoice"), "GET");-}} else {-    response.Say("No status selection made, goodbye.").Redirect(new Uri($"{Config.SystemBehaviorConfig.ResgridApiBaseUrl}/api/Twilio/InboundVoice"), "GET");+    var message = String.IsNullOrWhiteSpace(twilioRequest.Digits)+        ? "No status selection made, goodbye."+        : "Invalid status selection, goodbye.";+    response.Say(message).Redirect(new Uri($"{Config.SystemBehaviorConfig.ResgridApiBaseUrl}/api/Twilio/InboundVoice"), "GET"); }

---

911-919:Apply same error handling consolidation

Similar to the status endpoint, the error handling here could be consolidated.

-else-{-    response.Say("Invalid staffing selection, goodbye.").Redirect(new Uri($"{Config.SystemBehaviorConfig.ResgridApiBaseUrl}/api/Twilio/InboundVoice"), "GET");-}} else {-    response.Say("No staffing selection made, goodbye.").Redirect(new Uri($"{Config.SystemBehaviorConfig.ResgridApiBaseUrl}/api/Twilio/InboundVoice"), "GET");+    var message = String.IsNullOrWhiteSpace(twilioRequest.Digits)+        ? "No staffing selection made, goodbye."+        : "Invalid staffing selection, goodbye.";+    response.Say(message).Redirect(new Uri($"{Config.SystemBehaviorConfig.ResgridApiBaseUrl}/api/Twilio/InboundVoice"), "GET"); }

---

930-936:Consider proper namespace for TwilioMessage class

TheTwilioMessage class is defined at the bottom of the controller file. Consider moving it to a separate file in the Models namespace for better organization and maintainability.

Would you like me to help create a separate model file for theTwilioMessage class to improve code organization?

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro