- Notifications
You must be signed in to change notification settings - Fork343
Fix race condition issue in combineLatest#402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
AdamPitt7 wants to merge1 commit intoReactiveX:masterChoose a base branch fromAdamPitt7:fix-combine-latest-race-condition
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Fix race condition issue in combineLatest#402
AdamPitt7 wants to merge1 commit intoReactiveX:masterfromAdamPitt7:fix-combine-latest-race-condition
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix a race condition in the combineLatest function.
I was getting nil pointer exceptions when using combineLatest callback function
f FuncNwith multiple observables which are also using combineLatest.From what I can tell, the race condition is caused when one observable has incremented the counter, but has not yet set the cache variable
s[i] = item.VMeanwhile, another observable is checking if the counter is equal to the number of observables
atomic.LoadUint32(&counter) == sizeand then calling the callback function with the cache variable which now includes a nil value.By moving the counter increment into the lock, this should fix the race condition issue.