Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

delete escaping for subscription constructor where sink closuer be called immediately#518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Fushj89 wants to merge1 commit intoReSwift:master
base:master
Choose a base branch
Loading
fromFushj89:delete-escaping-for-subscription-constructor

Conversation

@Fushj89
Copy link

@Fushj89Fushj89 commentedNov 12, 2024•
edited
Loading

`
public class Subscription {

/// Initializes a subscription with a sink closure. The closure provides a way to send/// new values over this subscription.public init(sink: @escaping (@escaping (State?, State) -> Void) -> Void) {    // Provide the caller with a closure that will forward all values    // to observers of this subscription.    sink { old, new in        self.newValues(oldState: old, newState: new)    }}

}
`

sink clouser called immediately, not need use@escaping

@Fushj89Fushj89 changed the titledelete escaping for subscription constructor cause sink closuer called immediatelydelete escaping for subscription constructor where sink closuer be called immediatelyNov 12, 2024
@Fushj89
Copy link
Author

@DivineDominion please help review th pr

@DivineDominion
Copy link
Contributor

@Fushj89 I've triggered a CI build to test things, thanks for the submission! I'm surprised this wasn't noticed earlier :)

@Fushj89
Copy link
Author

@DivineDominion Thanks for your reply. All CI checks have passed, can you help to merge the pr?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Fushj89@DivineDominion
[8]ページ先頭
©2009-2025 Movatter.jp