- Notifications
You must be signed in to change notification settings - Fork60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
e2e: Add ClusterSet validation#1955
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code looks good, but it seems to belong to the validate package.
e2e/util/clusterset.go Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This seems to belong to the validate package, and all the function can be private since they are used by the validate package.
We should not add new code to the util package unless we don't have a better way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ack, done.
Added clustersInClusterSet function to validate that theconfigured clusters exist in the specified ClusterSet.Ensures test config validation fails early if the ClusterSetis misconfigured or the clusters are not part of it.Signed-off-by: Parikshith <parikshithb@gmail.com>
95e529a to60251b9Compare
Added clustersInClusterSet function to validate that the configured clusters exist in the specified ClusterSet. Ensures test config validation fails early if the ClusterSet is misconfigured or the clusters are not part of it.
Testing:
Fixes#1904