- Notifications
You must be signed in to change notification settings - Fork60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Initial ramen label changes#1741
Open
abhijeet219 wants to merge1 commit intoRamenDR:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Please add content to the commit message/pr message explaining the purpose of the change and linking to the relevant issues. |
7ead978 to58250a1CompareWe need to add another label ramendr.openshift.io/exclude=true |
raghavendra-talur requested changesMar 7, 2025
I have two comments asking for changes. In addition to that, please add the commit messages like Nir has requested. We should also write a unit test/e2e that verifies that all the objects have the label. |
raghavendra-talur requested changesMar 21, 2025
Introducing a label to be added to all the resourcescreated by Ramen.Signed-off-by: Abhijeet Shakya <abhijeetshakya21@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress...
Introducing a new label to be added to all the resources created by Ramen.
Addressingissue