This repository was archived by the owner on Jul 10, 2025. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork5
Transforming string concatenations to template strings#10
Draft
julian-schneider wants to merge1 commit intoRTVision:masterChoose a base branch fromjulian-schneider:allow-string-concat
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
warning: this code transforms any line containing `import(...)` to a template string without checking the original content. If the original line was not even a string concatenation, but e.g. part of a regex, it breaks it.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Addresses#8.
Draft PR with hacky code that transforms any line containing
import(...)to a template string as a preprocessing step, but without checking the original content.If the original line was not even a string concatenation, but e.g. part of a regexas happening here, it breaks the regex.
If the user is aware of this risk, the code can be used in combination with the
filteroption, as to not break other module code. But it would be nicer to be able to prevent the issue entirely:Normally,this line does a final check if the import statement contains a template string. But since the new code has transformed
destinationFileto a template string already, the check is now useless. If this condition was changed to effectively check whether the original line was either a template string, or a valid import statement containing simple string concatenation, this code should work fine. But I did not find a robust way to check that.An alternative to using this code would be to let ESLint do the job: Theprefer-template rule can be enforced via the
--fixoption, which might be a robust preprocessing step for string concatenation.