Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[add][RTduino] Fitter RTduino in frdm-mcxa346#11067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
westcity-YOLO wants to merge4 commits intoRT-Thread:master
base:master
Choose a base branch
Loading
fromwestcity-YOLO:mcxa346-Rtduino

Conversation

@westcity-YOLO
Copy link
Contributor

拉取/合并请求描述：(PR description)

[

Fitter RTduino in frdm-mcxa346

  • BSP:
    \bsp\nxp\mcx\mcxa\frdm-mcxa346

  • .config:

  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies withRT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions
Copy link

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击Run workflow | ClickRun workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：mcxa346-Rtduino
  • 设置PR number为 \ Set the PR number to：11067
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至mcxa346-Rtduino 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to themcxa346-Rtduino branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actionsgithub-actionsbot added BSP: NXPCode related with NXP BSP labelsDec 16, 2025
@github-actions
Copy link

github-actionsbot commentedDec 16, 2025•
edited
Loading

📌 Code Review Assignment

🏷️ Tag: bsp_mcxa

Reviewers: hywing

Changed Files (Click to expand)
  • bsp/nxp/mcx/mcxa/Libraries/drivers/drv_pin.h
  • bsp/nxp/mcx/mcxa/frdm-mcxa346/.cl/attachconfig/RTduino.attach
  • bsp/nxp/mcx/mcxa/frdm-mcxa346/applications/SConscript
  • bsp/nxp/mcx/mcxa/frdm-mcxa346/applications/arduino_main.cpp
  • bsp/nxp/mcx/mcxa/frdm-mcxa346/applications/arduino_pinout/RTduino-peripherals.png
  • bsp/nxp/mcx/mcxa/frdm-mcxa346/applications/arduino_pinout/SConscript
  • bsp/nxp/mcx/mcxa/frdm-mcxa346/applications/arduino_pinout/frdm-mcxa346-pinout1.jpg
  • bsp/nxp/mcx/mcxa/frdm-mcxa346/applications/arduino_pinout/frdm-mcxa346-pinout2.jpg
  • bsp/nxp/mcx/mcxa/frdm-mcxa346/applications/arduino_pinout/pins_arduino.c
  • bsp/nxp/mcx/mcxa/frdm-mcxa346/applications/arduino_pinout/pins_arduino.h
  • bsp/nxp/mcx/mcxa/frdm-mcxa346/board/Kconfig

📊 Current Review Status (Last Updated: 2025-12-17 14:54 CST)

  • ⌛hywing Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态:🔄 刷新状态
    Maintainers can refresh the review status by clicking here:🔄 Refresh Status

  2. 确认审核通过后评论LGTM/lgtm
    CommentLGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️刷新CI状态操作需要具备仓库写入权限。
ℹ️Refresh CI status operation requires repository Write permission.

@Rbb666
Copy link
Member

select BSP_USING_GPIO
select BSP_USING_ADC
select BSP_USING_ADC0
select BSP_USING_ADC0_CH0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

上面pins_arduino.c对应的驱动这块没加上，另外在rtduino软件包下有测试过这些外设吗

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

老师这个文件已经修改对应的 但是外设还没有来得及全部测试 后续有时间我会回测试然后添加到支持列表里面

@kurisaW
Copy link
Member

另外测试通过后麻烦在这里添加一下对应的bsp支持说明：https://github.com/RTduino/RTduino/blob/master/README.md#2-%E5%B7%B2%E7%BB%8F%E9%80%82%E9%85%8Drtduino%E7%9A%84rt-thread-bsp

@westcity-YOLO
Copy link
ContributorAuthor

建议作者添加下rtduino的ci编译看护：

https://github.com/RT-Thread/rt-thread/blob/master/bsp/stm32/stm32f407-rt-spark/.ci/attachconfig/ci.attachconfig.yml

https://club.rt-thread.org/ask/article/5edd0f0940a57129.html

好滴 老师已经添加 新的pr测试提交中已经mcxa已经编译通过

@westcity-YOLO
Copy link
ContributorAuthor

另外测试通过后麻烦在这里添加一下对应的bsp支持说明：https://github.com/RTduino/RTduino/blob/master/README.md#2-%E5%B7%B2%E7%BB%8F%E9%80%82%E9%85%8Drtduino%E7%9A%84rt-thread-bsp

好滴 老师 等我后续完成测试我会添加到支持里面并且在application下面添加rtduino适配说明

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kurisaWkurisaWkurisaW left review comments

@Rbb666Rbb666Rbb666 approved these changes

@mysterywolfmysterywolfAwaiting requested review from mysterywolfmysterywolf is a code owner

Assignees

No one assigned

Labels

BSP: NXPCode related with NXPBSP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@westcity-YOLO@Rbb666@kurisaW
[8]ページ先頭
©2009-2025 Movatter.jp