Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[BSP]适配珠海泰为tae32g5800的部分外设(GPIO/UART/CAN/FDCAN/IWDG/FAL)#10951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
yeminlong wants to merge1 commit intoRT-Thread:master
base:master
Choose a base branch
Loading
fromyeminlong:master

Conversation

@yeminlong
Copy link

@yeminlongyeminlong commentedNov 17, 2025•
edited
Loading

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

新增BSP--适配珠海泰为tae32g5800的部分外设(GPIO/UART/CAN/FDCAN/IWDG/FAL)

请提供验证的bsp和config (provide the config and bsp)

  • BSP: bsp/tae32/tae32g5800_eval_board
  • .config: bsp/tae32/tae32g5800_eval_board/.config
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • [ ] 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies withRT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@CLAassistant
Copy link

CLAassistant commentedNov 17, 2025•
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击Run workflow | ClickRun workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：master
  • 设置PR number为 \ Set the PR number to：10951
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至master 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to themaster branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@meng-plus
Copy link
Contributor

根据bsp瘦身计划 您的提交可能不会被合并
为提高复用 厂家驱动库 要求统一的管理方式

@yeminlongyeminlong marked this pull request as ready for reviewNovember 18, 2025 01:14
@Rbb666Rbb666 requested a review fromCopilotNovember 18, 2025 01:42
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This pull request adds Board Support Package (BSP) support for the Zhuhai Taiwei TAE32G5800 microcontroller, implementing peripheral drivers for GPIO, UART, CAN, FDCAN, IWDG, and FAL (Flash Abstraction Layer).

Key Changes

  • New BSP directory structure for TAE32G5800 evaluation board
  • Firmware library including TAE32G58xx device drivers and CMSIS core files
  • Peripheral driver implementations for GPIO, UART, CAN/FDCAN, and IWDG
  • Build configuration files (SConscript, Kconfig, linker scripts for GCC and ARM)
  • OpenOCD configuration files and startup code for the TAE32G58xx series

Reviewed Changes

Copilot reviewed 39 out of 194 changed files in this pull request and generated 8 comments.

Show a summary per file
FileDescription
bsp/tae32/libraries/TAE32G58xx_Firmware_Library/TAE32G58xx_Driver/Inc/*.hADC and general low-level driver header files
bsp/tae32/libraries/TAE32G58xx_Firmware_Library/TAE32G58xx_Device/Src/*.cSystem initialization and startup code
bsp/tae32/libraries/TAE32G58xx_Firmware_Library/TAE32G58xx_Device/Src/GCC/*GCC linker scripts and OpenOCD configuration
bsp/tae32/libraries/TAE32G58xx_Firmware_Library/TAE32G58xx_Device/Src/ARM/*ARM compiler scatter files
bsp/tae32/libraries/TAE32G58xx_Firmware_Library/TAE32G58xx_Device/Inc/*.hDevice and system header files
bsp/tae32/libraries/TAE32G58xx_Firmware_Library/SConscriptSCons build script for library compilation
bsp/tae32/libraries/TAE32G58xx_Firmware_Library/CMSIS/Include/*.hCMSIS core support headers
bsp/tae32/libraries/KconfigKconfig configuration for TAE32 SOC family
bsp/tae32/libraries/.ignore_format.ymlFormat check exclusion configuration

#define __LL_ADC_CalMode_Get(__ADC__) READ_BIT_SHIFT((__ADC__)->CR, ADC0_CR_ADCALDIF_Msk, ADC0_CR_ADCALDIF_Pos)

/**
* @brief Calibration Start

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

English: Trailing whitespace after "Start" on line 85. Remove the extra space at the end of the comment.
中文：第 85 行 "Start" 后面有多余的空格。请删除注释末尾的多余空格。

Suggested change
* @briefCalibrationStart
* @briefCalibrationStart

Copilot uses AI. Check for mistakes.
#define __LL_ADC_Cal_Start(__ADC__) SET_BIT((__ADC__)->CR, ADC0_CR_ADCAL_Msk)

/**
* @brief Judge is Calibration Starting or not

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

English: Trailing whitespace after "not" on line 92. Remove the extra space at the end of the comment.
中文：第 92 行 "not" 后面有多余的空格。请删除注释末尾的多余空格。

Suggested change
* @briefJudgeisCalibrationStartingornot
* @briefJudgeisCalibrationStartingornot

Copilot uses AI. Check for mistakes.
/*
* SG veneers:
* All SG veneers are placed in the special output section .gnu.sgstubs. Its start address
* must be set, either with the command line option �--section-start� or in a linker script,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

English: Line 137 contains an invalid character '�' (likely a corrupted em-dash). Replace with proper ASCII characters like "--section-start".
中文：第 137 行包含无效字符 '�'(可能是损坏的破折号)。请替换为正确的 ASCII 字符,如 "--section-start"。

Suggested change
* must be set, either with the command line option�--section-start� or in a linker script,
* must be set, either with the command line option --section-start or in a linker script,

Copilot uses AI. Check for mistakes.
/*
* SG veneers:
* All SG veneers are placed in the special output section .gnu.sgstubs. Its start address
* must be set, either with the command line option �--section-start� or in a linker script,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

English: Line 137 contains an invalid character '�' (likely a corrupted em-dash). Replace with proper ASCII characters like "--section-start".
中文：第 137 行包含无效字符 '�'(可能是损坏的破折号)。请替换为正确的 ASCII 字符,如 "--section-start"。

Suggested change
* must be set, either with the command line option�--section-start� or in a linker script,
* must be set, either with the command line option --section-start or in a linker script,

Copilot uses AI. Check for mistakes.
* Secondary data section, optional
*
* Remember to add each additional data section
* to the .copy.table above to asure proper

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

English: "asure" should be spelled "assure" on line 243.
中文：第 243 行 "asure" 应拼写为 "assure"。

Copilot uses AI. Check for mistakes.
* Secondary bss section, optional
*
* Remember to add each additional bss section
* to the .zero.table above to asure proper

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

English: "asure" should be spelled "assure" on line 278.
中文：第 278 行 "asure" 应拼写为 "assure"。

Suggested change
* to the .zero.table above toasure proper
* to the .zero.table above toassure proper

Copilot uses AI. Check for mistakes.
* Secondary data section, optional
*
* Remember to add each additional data section
* to the .copy.table above to asure proper

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

English: "asure" should be spelled "assure" on line 243.
中文：第 243 行 "asure" 应拼写为 "assure"。

Copilot uses AI. Check for mistakes.
* Secondary bss section, optional
*
* Remember to add each additional bss section
* to the .zero.table above to asure proper

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

English: "asure" should be spelled "assure" on line 278.
中文：第 278 行 "asure" 应拼写为 "assure"。

Suggested change
* to the .zero.table above toasure proper
* to the .zero.table above toassure proper

Copilot uses AI. Check for mistakes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

关于芯片的BSP驱动库已经不可以加入到master了，还请使用软件包形式提交，谢谢

请参考：https://club.rt-thread.org/ask/article/4839095b91c2f849.html

@Rbb666Rbb666 added the -1No vote labelNov 18, 2025
@Rbb666
Copy link
Member

@yeminlong 作者有联系方式吗？我们可以加个好友看看怎么推动下

@yeminlong
Copy link
Author

@Rbb666 已通过B站的站内消息发送了联系方式，感谢支持！

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@Rbb666Rbb666Rbb666 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

-1No voteBSP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yeminlong@CLAassistant@meng-plus@Rbb666
[8]ページ先頭
©2009-2025 Movatter.jp