- Notifications
You must be signed in to change notification settings - Fork8.1k
Fix dependencies, error handling, and package validation#26525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Copilot wants to merge4 commits intomasterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+22 −9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ng, and scenario conditionsCo-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
…ageManagerCo-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
CopilotAI changed the title[WIP] Apply changes based on review commentsApply review comments from PR #26504: fix dependencies, error handling, and package validationNov 24, 2025
TravisEz13 approved these changesNov 24, 2025
tools/packaging/packaging.psm1 Outdated
| # Build the package using dpkg-deb | ||
| $debFileName="${Name}_${Version}-${Iteration}_${HostArchitecture}.deb" | ||
| $debFileName="${Name}_${Version}-${Iteration}.deb_${HostArchitecture}.deb" |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@copilot This created an invalid file name
WARNING: powershell_7.6.0-preview.6-1.deb.deb_amd64.deb is not a valid DEB package nameError: [-] Linux Package Name Validation.DEB Package Names.Should have valid DEB package names 59ms (58ms|2ms)Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
Contributor
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for15 days. It will be closed if no further activity occurswithin 10 days of this comment. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
CL-BuildPackagingIndicates that a PR should be marked as a build or packaging change in the Change Log StaleWaiting on AuthorThe PR was reviewed and requires changes or comments from the author before being accept
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
Addresses review comments from PR#26504 to fix DEB package generation, dependency checking, and build scenario conditions.
PR Context
The original PR#26504 replaced
fpmwith nativedpkg-debfor DEB package generation. This PR fixes issues identified in code review:Dependency Management
New-NativeDeb: Omit emptyDepends:field when no dependencies specified (prevents invalid control file)Test-Dependencies: Add platform-specific checks fordpkg-deb(Debian) andrpmbuild(RPM systems), not just MarinerPackage Validation
name_version-iteration.deb_arch.deb(wasname_version-iteration_arch.deb)~rc.1) and variable iteration (-\dvs-1) to match pipeline validationError Handling
Get-Errorand rethrow exceptions (was silently swallowing errors)Build System
'All'option in all 4 package-related checks (Ubuntu/Debian, RedHat/Mariner, SUSE, Windows WiX)Write-LogGroupwithWrite-LogGroupStart/Write-LogGroupEndPR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn moreCopilot coding agent tips in the docs.