Commit8948c41

authored

Make Export-Csv -Append and -NoHeader mutually exclusive (#26472)

1 parentf4476c5 commit8948c41Copy full SHA for 8948c41

File tree

+15

-0

lines changed

src/Microsoft.PowerShell.Commands.Utility
- commands/utility
  - CsvCommands.cs
- resources
  - CsvCommandStrings.resx
test/powershell/Modules/Microsoft.PowerShell.Utility
- Export-Csv.Tests.ps1

+15

-0

lines changed

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -270,6 +270,14 @@ protected override void BeginProcessing()`
`270`	`270`	`this.ThrowTerminatingError(errorRecord);`
`271`	`271`	`}`
`272`	`272`
	`273`	`+// Validate that Append and NoHeader are not specified together.`
	`274`	`+if(Append&&NoHeader)`
	`275`	`+{`
	`276`	`+InvalidOperationExceptionexception=new(CsvCommandStrings.CannotSpecifyAppendAndNoHeader);`
	`277`	`+ErrorRecorderrorRecord=new(exception,"CannotSpecifyBothAppendAndNoHeader",ErrorCategory.InvalidData,null);`
	`278`	`+this.ThrowTerminatingError(errorRecord);`
	`279`	`+}`
	`280`	`+`
`273`	`281`	`_shouldProcess=ShouldProcess(Path);`
`274`	`282`	`if(!_shouldProcess)`
`275`	`283`	`{`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -157,4 +157,7 @@`
`157`	`157`	`<dataname="EOFIsReached"xml:space="preserve">`
`158`	`158`	`<value>EOF is reached.</value>`
`159`	`159`	`</data>`
	`160`	`+ <dataname="CannotSpecifyAppendAndNoHeader"xml:space="preserve">`
	`161`	`+ <value>You must specify either the -Append or -NoHeader parameters, but not both.</value>`
	`162`	`+ </data>`
`160`	`163`	`</root>`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -187,6 +187,10 @@ Describe "Export-Csv" -Tags "CI" {`
`187`	`187`	`$results[1].PSObject.properties.Name\| Should-Not-Contain'third'`
`188`	`188`	`}`
`189`	`189`
	`190`	`+ It"Should throw when -Append and -NoHeader are specified together" {`
	`191`	`+ {$P1\|Export-Csv-Path$testCsv-Append-NoHeader-ErrorAction Stop }\| Should-Throw-ErrorId"CannotSpecifyBothAppendAndNoHeader,Microsoft.PowerShell.Commands.ExportCsvCommand"`
	`192`	`+ }`
	`193`	`+`
`190`	`194`	`It"First line should be #TYPE if -IncludeTypeInformation used and pstypenames object property is empty" {`
`191`	`195`	`$object= [PSCustomObject]@{first=1}`
`192`	`196`	`$pstypenames=$object.pstypenames\|ForEach-Object-Process {$_}`

Comments

(0)