Commitaeb5313

committed

Return helpful error when an empty list of docs are imported.

1 parentbb2a15c commitaeb5313Copy full SHA for aeb5313

File tree

+11

-1

lines changed

+11

-1

lines changed

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`	`importos`
`3`	`3`	`importsys`
`4`	`4`	`importtypesense`
`5`		`-`
	`5`	`+fromtypesense.exceptionsimportTypesenseClientError`
`6`	`6`
`7`	`7`	`curr_dir=os.path.dirname(os.path.realpath(__file__))`
`8`	`8`	`sys.path.insert(1,os.path.abspath(os.path.join(curr_dir,os.pardir)))`
`@@ -131,6 +131,13 @@`
`131`	`131`	`# Deleting documents matching a filter query`
`132`	`132`	`print(client.collections['books'].documents.delete({'filter_by':'ratings_count: 4780653'}))`
`133`	`133`
	`134`	`+# Try importing empy list`
	`135`	`+try:`
	`136`	`+import_results=client.collections['books'].documents.import_([], {"action":"upsert"})`
	`137`	`+print(import_results)`
	`138`	`+exceptTypesenseClientErrorase:`
	`139`	`+print("Detected import of empty document list.")`
	`140`	`+`
`134`	`141`	`# Drop the collection`
`135`	`142`	`drop_response=client.collections['books'].delete()`
`136`	`143`	`print(drop_response)`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,9 @@ def import_(self, documents, params=None, batch_size=None):`
`74`	`74`	`fordocumentindocuments:`
`75`	`75`	`document_strs.append(json.dumps(document))`
`76`	`76`
	`77`	`+iflen(document_strs)==0:`
	`78`	`+raiseTypesenseClientError(f"Cannot import an empty list of documents.")`
	`79`	`+`
`77`	`80`	`docs_import='\n'.join(document_strs)`
`78`	`81`	`api_response=self.api_call.post(self._endpoint_path('import'),docs_import,params,as_json=False)`
`79`	`82`	`res_obj_strs=api_response.split('\n')`

Comments

(0)