Commit7fa871b

authored

Merge pull requesttypesense#29 from OrionReed/master

Throw error if search parameters are not all strings

2 parentsca568b3 +8d6a01b commit7fa871bCopy full SHA for 7fa871b

File tree

+25

-2

lines changed

+25

-2

lines changed

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,8 @@`
`4`	`4`
`5`	`5`	`from .documentimportDocument`
`6`	`6`	`from .loggerimportlogger`
	`7`	`+from .validationimportvalidate_search`
	`8`	`+from .preprocessimportstringify_search_params`
`7`	`9`	`fromcollections.abcimportIterable`
`8`	`10`
`9`	`11`	`classDocuments(object):`
`@@ -94,7 +96,9 @@ def export(self, params=None):`
`94`	`96`	`returnapi_response`
`95`	`97`
`96`	`98`	`defsearch(self,search_parameters):`
`97`		`-returnself.api_call.get(self._endpoint_path('search'),search_parameters)`
	`99`	`+stringified_search_params=stringify_search_params(search_parameters)`
	`100`	`+validate_search(stringified_search_params)`
	`101`	`+returnself.api_call.get(self._endpoint_path('search'),stringified_search_params)`
`98`	`102`
`99`	`103`	`defdelete(self,params=None):`
`100`		`-returnself.api_call.delete(self._endpoint_path(),params)`
	`104`	`+returnself.api_call.delete(self._endpoint_path(),params)`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -45,3 +45,7 @@ class ServiceUnavailable(TypesenseClientError):`
`45`	`45`
`46`	`46`	`classHTTPStatus0Error(TypesenseClientError):`
`47`	`47`	`pass`
	`48`	`+`
	`49`	`+`
	`50`	`+classInvalidParameter(TypesenseClientError):`
	`51`	`+pass`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,8 @@`
	`1`	`+defstringify_search_params(params):`
	`2`	`+return {key:stringify(val)forkey,valinparams.items()}`
	`3`	`+`
	`4`	`+defstringify(val):`
	`5`	`+ifisinstance(val,bool)orisinstance(val,int):`
	`6`	`+returnstr(val).lower()`
	`7`	`+else:`
	`8`	`+returnval`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,7 @@`
	`1`	`+fromtypesense.exceptionsimportInvalidParameter`
	`2`	`+`
	`3`	`+`
	`4`	`+defvalidate_search(params):`
	`5`	`+forkeyinparams:`
	`6`	`+ifnotisinstance(params[key],str):`
	`7`	`+raiseInvalidParameter(f"'{key}' field expected a string but was given{type(params[key]).__name__}")`

Comments

(0)