- Notifications
You must be signed in to change notification settings - Fork183
Fix HA Peer Serial location#562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
devyntk wants to merge1 commit intoPaloAltoNetworks:developChoose a base branch
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
FliesLikeABrick approved these changesMay 21, 2024
FliesLikeABrick commentedMay 21, 2024
@shinmog@btorresgil long time no talk - would either of you be available for review? |
adambaumeister approved these changesMay 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks correct to me based on our other codebases,@horiagunica if you've got a firewall running in HA mode can you just double check?
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
During testing and attempts to create HA pairs during initialization of a device tree from Panorama, I noticed that I was unable to get the HA peer serial, and after some investigation I found that this path was incorrect from the XML I was able to test against.
How Has This Been Tested?
This has been run against an environment with several Panorama and Firewall devices on PAN-OS 10.2.
Types of changes
Checklist