- Notifications
You must be signed in to change notification settings - Fork183
Upgrade subsystem overhaul#540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
btorresgil wants to merge2 commits intodevelopChoose a base branch
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The software updater installed the base image before installing thepatch image for each major and minor release. This comes with thedisadvantage that the base image might have bugs and is running for ashort time before the patch upgrade begins. To avoid these potentialbugs in the base image, a new option to skip installing the base imageis now possible.
f986e03 to388da2dComparevrpal commentedJan 30, 2024
Hello, Does this fix suppose to cover upgrade from 10.2.x to 11 ? I'm not having any luck going from 10.2.7 to for example 11.0.2-h2 |
Now sure if this is still needed..?@jamesholland-uk and I did#548 to expand updater logic. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
Motivation and Context
10.2.x is the only minor release that does not have a 0 or 1, so needed to add a special case for it in the upgrade logic.
This new upgrade behavior to use patch releases instead of base images is in-line with modern guidance and best practices. It leverages the latest fixes during upgrades rather than the base image which will have more bugs. Upgrades can take a little longer because 2 images need to be downloaded instead of 1 (the base image and the patch image) but there is still only 1 upgrade for each minor release so this difference is negligible and worth the benefit of using safer patched images as intermediate versions.
NOTE: This new behavior is opt-in. This is not a breaking change.
How Has This Been Tested?
Tested on live firewall and via new test suite.
Types of changes
Checklist