- Notifications
You must be signed in to change notification settings - Fork195
fix: prevent duplicate native handler registrations#1085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
sherwinski wants to merge3 commits intomainChoose a base branch fromperf/duplicate-native-handlers
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Added flags to ensure addEventListener() only registers each nativehandler once per event type, eliminating unnecessary `cordova.exec` calls.This fix is applied to the InAppMessages, Notifications, User, and PushSubscription namespaces.
d608ec1 to9d144c1CompareContributorAuthor
sherwinski commentedOct 28, 2025
I'm not sure if this is a realistic concern but thought I'd raise it anyways for discussion. |
f9ef46e to80ffffaCompare3c70db9 to0997dcfComparee9bf279 to234f334CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
One Line Summary
Added flags to ensure
addEventListener()only registers each native handler once per event type, eliminating unnecessarycordova.execcalls.Details
Motivation
I noticed that we may be creating too many native handlers, once per each invocation of
addEventListener(). This could cause a potential memory leak in the consuming applications.Scope
Any
addEventListenerfunction across theInAppMessages,Notifications,User, andPushSubscriptionnamespaces.Testing
Unit testing
One tested added that ensures that
cordova.execis only called once, no matter how many event listeners are added.Affected code checklist
Checklist
Overview
Testing
Final pass
This change is