Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork190
Fix User Disabled Security Pattern Flow#329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
aserranoalliax wants to merge2 commits intoNiklasMerz:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Fix User Disabled Security Pattern Flow#329
aserranoalliax wants to merge2 commits intoNiklasMerz:masterfromalliaxcorp:user-disabled-security-pattern
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
1.- Fix the flow when a user disable all the security, it implements after removeKey also remove the preferences store in memory and throw BIOMETRIC_NO_SECRET_FOUND until new key have been created2.- Also split methods of create and create key for better maintance.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The plugin can't recover when user disable security pattern and try to load a new secret, the method KeyStore.getKey throw an exception and says "user changed or deleted their auth credentials", it was added a method to also remove ciphertext and IV initializationVector from app storage in order to show the message BIOMETRIC_NO_SECRET_FOUND and manage exceptions to deleteKey and storage keys from app
How did you test your changes?
I tested on a Pixel 4 emulator and also in a SM-N9600 Samsung Note 9