This repository was archived by the owner on Jul 8, 2024. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork535
fix(types) change vibrate to a number array#274
Open
rob4226 wants to merge1 commit intoNickersoft:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Currently the typescript type definition shows that vibrate is a booleanbut per the docs it should be a number array:An array of durations for a mobile device receiving the notification tovibrate. For example, [200, 100] would vibrate first for 200 milliseconds,pause, then continue for 100 milliseconds. For more information, see below.Available in Mobile Chrome only.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the typescript type definition shows that vibrate is a boolean
but per the docs it should be a number array:
Note: I only wanted to change
index.d.tsandsrc/types.jsbut it looks like the precommit script forces a build anyway so not sure what changed in the other files. Thanks.