- Notifications
You must be signed in to change notification settings - Fork761
Initial build system updates for monorepo#1946
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| # This must be done before any languages are enabled: | ||
| if (THRUST_TOPLEVEL_PROJECT) | ||
| cmake_minimum_required(VERSION 3.21) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The nameThrustCompilerHacks doesn't really make sense anymore.ThrustSetCUDAHostCompiler makes it clear what is being done.
Uh oh!
There was an error while loading.Please reload this page.
| ${CMAKE_CUDA14_COMPILE_FEATURES} | ||
| ${CMAKE_CUDA17_COMPILE_FEATURES} | ||
| ${CMAKE_CUDA20_COMPILE_FEATURES} | ||
| set(tmp"${CMAKE_CUDA_HOST_COMPILER}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We can remove this check from all projects.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In this file, I think we should update theset(thrust_libcudacxx_version XXX) to just always be the same as the Thrust version itself.
Now that we will be synchronizing versions across components, we aren't going to try and support mix&match different versions of components.
| target_compile_options(thrust.compiler_interfaceINTERFACE | ||
| # If using CUDA w/ NVCC... | ||
| $<$<AND:$<COMPILE_LANGUAGE:CUDA>,$<CUDA_COMPILER_ID:NVIDIA>>:-Wno-deprecated-gpu-targets> | ||
| $<$<COMPILE_LANG_AND_ID:CUDA,NVIDIA>:-diag-suppress 128> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is this still needed? Add a comment if so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Line 13 is clobbering theCMAKE_CUDA_FLAGS argument, which prevents specifying-DCMAKE_CUDA_FLAGS="-DTHRUST_IGNORE_DEPRECATED_CPP_DIALECT -DCUB_IGNORE_DEPRECATED_CPP_DIALECT"
This allows the install rules to be generated for all projects evenwhen the dev builds are disabled.
These are now handled at the CCCL level, using newer and morerobust techniques.
No description provided.