- Notifications
You must be signed in to change notification settings - Fork341
Correct right mouse drag in X behavior#283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
gbburkhardt wants to merge3 commits intoNASAWorldWind:developChoose a base branch
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…n that is maintained by JOGAMP. Update JOGL jar files with released version 2.5.0, build Build: 2.5-b1533-20230818. That build includes the DPI scaling fix for TextRenderer, which was committed to the jogl repo on 6/4.
The desired behavior is to have the globe follow the mouse movement, e.g.,when the mouse is above mid-screen, dragging the mouse to the right shouldcause a clockwise rotation of the globe. The change from AWT to GL screencoordinates had broken this. Thanks to Eugene Maksymenko (WorldWindEarth).
PJHogan approved these changesDec 31, 2024
PJHogan approved these changesDec 31, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Filling out this template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the
maintainer's discretion.
Description of the Change
Correct change in heading by dragging the right mouse button in the X direction.
The desired behavior is to have the globe follow the mouse movement, e.g.,
when the mouse is above mid-screen, dragging the mouse to the right should
cause a clockwise rotation of the globe. The change from AWT to GL screen
coordinates had broken this. Thanks to Eugene Maksymenko (WorldWindEarth).
Why Should This Be In Core?
Restore original intent for mouse movements.
Benefits
More intuitive mouse control. Restore original intent for mouse movements.
Potential Drawbacks
None.
Applicable Issues