- Notifications
You must be signed in to change notification settings - Fork1.2k
Exclude pre-compiled packages matching excludes list#2075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
MickaelBergem wants to merge1 commit intoMiserlou:masterChoose a base branch fromMickaelBergem:master
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
There are some locally installed packages I don't want to install on mylambda function, such as coverage or mypy for instance. This changeprevents ignored packages from being included in the final ZIP file, savingme about 30% of the lambda size.
coveralls commentedApr 4, 2020
1 similar comment
coveralls commentedApr 4, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There are some locally installed packages I don't want to install on my lambda function, such as coverage or mypy. They are in the
excludesbut somehow are still included in the final ZIP. This change prevents ignored packages from being included in the final ZIP file, resulting for me in a 30% reduction of the lambda size.This works fine for me locally using Python3.7 and Python3.8
One caveat I just discovered is that patterns (like
packagename*) will not be interpreted and will be used as plain strings.Resulting output:
GitHub Issues
I have not opened a GitHub issue first, I'm happy to do it if it's really required, but a PR likely describes more what I want to do :)