Commit87f3bfe

committed

AppStore app: don't create unnecessary additional thread

1 parent51e702b commit87f3bfeCopy full SHA for 87f3bfe

File tree

-5

lines changed

internal_filesystem/builtin/apps/com.micropythonos.appstore/assets
- appstore.py

-5

lines changed

Lines changed: 1 addition & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -70,6 +70,7 @@ def download_app_index(self, json_url):`
`70`	`70`	`time.sleep_ms(200)`
`71`	`71`	`self.update_ui_threadsafe_if_foreground(self.please_wait_label.add_flag,lv.obj.FLAG.HIDDEN)`
`72`	`72`	`self.update_ui_threadsafe_if_foreground(self.create_apps_list)`
	`73`	`+self.download_icons()`
`73`	`74`	`exceptExceptionase:`
`74`	`75`	`print(f"ERROR: could not parse reponse.text JSON:{e}")`
`75`	`76`	`finally:`
`@@ -119,11 +120,6 @@ def create_apps_list(self):`
`119`	`120`	`desc_label.set_style_text_font(lv.font_montserrat_12,0)`
`120`	`121`	`desc_label.add_event_cb(lambdae,a=app:self.show_app_detail(a),lv.EVENT.CLICKED,None)`
`121`	`122`	`print("create_apps_list app done")`
`122`		`-try:`
`123`		`-_thread.stack_size(mpos.apps.good_stack_size())`
`124`		`-_thread.start_new_thread(self.download_icons,())# maybe there's no need for a new thread here, just do it in download_app_index()?`
`125`		`-exceptExceptionase:`
`126`		`-print("Could not start thread to download icons: ",e)`
`127`	`123`
`128`	`124`	`defdownload_icons(self):`
`129`	`125`	`forappinself.apps:`

Comments

(0)