Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork754
Support deserializing a 16 byte binary guid/uuid#2156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Support deserializing a 16 byte binary guid/uuid#2156
Conversation
neuecc commentedFeb 18, 2025
Since we can expect GUIDs to come in various formats, I agree with making the deserialization somewhat flexible. |
ramonsmits commentedFeb 18, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Fixed that
What does this mean? If many message pack serializeres serialize uuid as 16 byte big endian values?
I'm doing that now, but it felt such a common thing that I didn't expect that binary uuids were not supported. I didn't verify other runtimes/packages. As you can see there is significant size savings. Imaging a type that has a few uuid properties. That is 20 byte per uuid. |
ramonsmits commentedFeb 18, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@neuecc I also noticed this: NativeGuidFormatter: A remark on that type is the implementation only works on LITTLE endian environments. Would it be ok to refactor this PR into a new |
neuecc commentedFeb 21, 2025
seems good. |
When sending a uuid with javascript its a string. I tried sending a
Uint8Arraybut that failed to deserialize. Turns out in only supports text formatted uuid. This adds support for deserializing a 16 byte guid.